Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubelet] rename --cgroups-per-qos to --experimental-cgroups-per-qos #36767

Merged
merged 1 commit into from
Nov 15, 2016
Merged

[kubelet] rename --cgroups-per-qos to --experimental-cgroups-per-qos #36767

merged 1 commit into from
Nov 15, 2016

Conversation

vishh
Copy link
Contributor

@vishh vishh commented Nov 14, 2016 •
edited by k8s-oncall
Loading

This reflects the true nature of "cgroups per qos" feature.

 * Rename `--cgroups-per-qos` to `--experimental-cgroups-per-qos` in Kubelet

This change is Reviewable

@vishh vishh added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 14, 2016
@vishh vishh added this to the v1.5 milestone Nov 14, 2016
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 9278e985fb033dcabdf5c6e48b7e12e2600848c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 9278e985fb033dcabdf5c6e48b7e12e2600848c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 9278e985fb033dcabdf5c6e48b7e12e2600848c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 9278e985fb033dcabdf5c6e48b7e12e2600848c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 9278e985fb033dcabdf5c6e48b7e12e2600848c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 9278e985fb033dcabdf5c6e48b7e12e2600848c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 9278e985fb033dcabdf5c6e48b7e12e2600848c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@derekwaynecarr
Copy link
Member

The name change is fine. I know its used in hack/local-up as well, so we need to catch that area too.

@derekwaynecarr
Copy link
Member

update hack/local-up and get red x's to go, and then it will be good for me.

@vishh vishh force-pushed the rename-cgroups-flags branch from 9278e98 to c538144 Compare November 14, 2016 21:30
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit c538144b862a6459221b04f975a231f7b984dfad. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@vishh
[kubelet] rename --cgroups-per-qos to --experimental-cgroups-per-qos …
9066253 
…to reflect the true nature of that feature

Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh vishh force-pushed the rename-cgroups-flags branch from c538144 to 9066253 Compare November 14, 2016 22:06
@vishh
Copy link
Contributor Author

vishh commented Nov 14, 2016

@derekwaynecarr this PR should be good to go now.

@vishh
Copy link
Contributor Author

vishh commented Nov 14, 2016

Adding LGTM based on #36767 (comment)

@vishh vishh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3245e8b into kubernetes:master Nov 15, 2016
@mdshuai mdshuai mentioned this pull request Nov 15, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 15, 2016
Merge pull request #36800 from mdshuai/update-cgroups-per-qos
2110f72 
Automatic merge from submit-queue

[kubelet]update some --cgroups-per-qos to --experimental-cgroups-per-qos

Follow #36767, there are some fields still need update in docs or hack/local-up-cluster.sh
@jayunit100 jayunit100 mentioned this pull request Nov 16, 2016
Merged
michelleN pushed a commit to michelleN/community that referenced this pull request Nov 19, 2016
Merge pull request #36800 from mdshuai/update-cgroups-per-qos
5ee19a2 
Automatic merge from submit-queue

[kubelet]update some --cgroups-per-qos to --experimental-cgroups-per-qos

Follow kubernetes/kubernetes#36767, there are some fields still need update in docs or hack/local-up-cluster.sh
@saad-ali
Copy link
Member

Removing cherry-pick candidate label this is already in 1.5

@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dashpole dashpole

@derekwaynecarr derekwaynecarr

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
7 participants
@vishh @k8s-ci-robot @derekwaynecarr @k8s-github-robot @saad-ali @dashpole @googlebot