Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag allowing contention profiling of the API server #36756

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

gmarek
Copy link
Contributor

@gmarek gmarek commented Nov 14, 2016

Useful for performance debugging.

cc @smarterclayton @timothysc @lavalamp

Add a flag allowing contention profiling of the API server

This change is Reviewable

@gmarek gmarek added area/apiserver release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 14, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit c97633b. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@smarterclayton
Copy link
Contributor

lgtm

1 similar comment
@wojtek-t
Copy link
Member

lgtm

@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2016
@wojtek-t wojtek-t added this to the v1.5 milestone Nov 15, 2016
@gmarek
Copy link
Contributor Author

gmarek commented Nov 15, 2016

@saad-ali - it's a very safe change that is needed for performance debugging.

@gmarek
Copy link
Contributor Author

gmarek commented Nov 15, 2016

@k8s-bot gce test this issue: #IGNORE
timeout

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b2cd67c into kubernetes:master Nov 15, 2016
@timothysc
Copy link
Member

/cc @jeremyeder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apiserver lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants