Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up service retry timeouts #36282

Merged
merged 1 commit into from
Nov 5, 2016
Merged

Bump up service retry timeouts #36282

merged 1 commit into from
Nov 5, 2016

Conversation

bprashanth
Copy link
Contributor

@bprashanth bprashanth commented Nov 5, 2016 •
edited
Loading

Fixes #36266, #36282

This change is Reviewable

@bprashanth
Copy link
Contributor Author

@k8s-oncall going to hand merge if all tests pass to unblock SQ, see #36281

@bprashanth bprashanth added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 5, 2016
@MrHohn
Copy link
Member

MrHohn commented Nov 5, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2016
@bprashanth bprashanth added this to the v1.5 milestone Nov 5, 2016
@bprashanth bprashanth added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 5, 2016
@bprashanth
Copy link
Contributor Author

Apparently I can't hand merge, so raising to p0

@bprashanth bprashanth mentioned this pull request Nov 5, 2016
Closed
@saad-ali
Copy link
Member

saad-ali commented Nov 5, 2016

Merging to unblock queue

@saad-ali
Copy link
Member

saad-ali commented Nov 5, 2016

All checks have passed
12 successful checks

@saad-ali saad-ali merged commit 82ecd16 into kubernetes:master Nov 5, 2016
@saad-ali saad-ali mentioned this pull request Nov 5, 2016
Merged
@bprashanth bprashanth deleted the svc_test_dbg branch January 26, 2017 23:43
@tanjunchen tanjunchen mentioned this pull request Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MrHohn MrHohn

@saad-ali saad-ali

@piosz piosz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
7 participants
@bprashanth @MrHohn @saad-ali @googlebot @piosz @k8s-github-robot @k8s-ci-robot