Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: loadbalancer rules use DSR #36256

Merged
merged 1 commit into from
Nov 7, 2016
Merged

azure: loadbalancer rules use DSR #36256

merged 1 commit into from
Nov 7, 2016

Conversation

colemickens
Copy link
Contributor

@colemickens colemickens commented Nov 4, 2016 •
edited by k8s-oncall
Loading

What this PR does / why we need it:
Enables "direct server return" on the load balancer in Azure, which causes the DIP to be preserved when traffic goes through the load balancer. This enables service traffic to go to the Service Port rather than having to go through the NodePort.

Special notes for your reviewer:
N/A.

Tested with...:

kubectl run nginx --image=nginx
kubectl run nginx2 --image=nginx
kubectl expose deployment nginx --port=80 --type=LoadBalancer
kubectl expose deployment nginx2 --port=80 --type=LoadBalancer

Ensuring that both services got external IPs and that the resources created looked correct.

Release note:

azure: load balancer preserves destination ip address

CC: @brendandburns

This change is Reviewable

@colemickens
Copy link
Contributor Author

I have this built and pushed to docker.io/colemickens/hyperkube-amd64:colemickens-pr-azure-lb-dsr if anyone wants to test it. (That image has this commit cherry-picked on as well: #36231)

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Nov 4, 2016
@brendandburns brendandburns added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Nov 4, 2016
@brendandburns
Copy link
Contributor

LGTM.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2016
@colemickens
Copy link
Contributor Author

@k8s-bot test this

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 8c8fbbaaa47c00c5249448bb9f89745f0674d81f. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@colemickens colemickens force-pushed the colemickens-pr-azure-lb-dsr branch from 8c8fbba to 23454c1 Compare November 6, 2016 03:33
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 23454c1. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@colemickens
Copy link
Contributor Author

@k8s-bot cvm gce e2e test this

@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. cla: yes and removed cla: yes labels Nov 6, 2016
@colemickens colemickens closed this Nov 7, 2016
@colemickens colemickens deleted the colemickens-pr-azure-lb-dsr branch November 7, 2016 05:27
@colemickens colemickens restored the colemickens-pr-azure-lb-dsr branch November 7, 2016 05:32
@colemickens colemickens reopened this Nov 7, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit dc37723 into kubernetes:master Nov 7, 2016
@colemickens colemickens mentioned this pull request Nov 19, 2016
Merged
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@colemickens colemickens deleted the colemickens-pr-azure-lb-dsr branch December 15, 2016 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@colemickens @brendandburns @k8s-ci-robot @k8s-github-robot @googlebot @wojtek-t