Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powershell script to start kubelet and kube-proxy #36250

Merged
merged 3 commits into from
Jan 23, 2017
Merged

Powershell script to start kubelet and kube-proxy #36250

merged 3 commits into from
Jan 23, 2017

Conversation

jbhurat
Copy link
Contributor

@jbhurat jbhurat commented Nov 4, 2016 •
edited by k8s-oncall
Loading

What this PR does / why we need it:
This PR adds a powershell script to run kubelet and kube-proxy on Windows. It expects the required arguments like API Server location and uses appropriate defaults.

Which issue this PR fixes :
fixes # #34270

Special notes for your reviewer:
This PR is for supporting Windows Server Containers for k8s, the work for which is covered under kubernetes/enhancements#116
This PR should be merged after #31707 and #36079 PRs are merged

Release note:

This change is Reviewable

@jbhurat
Copy link
Contributor Author

jbhurat commented Nov 4, 2016

cc: @brendandburns

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Nov 4, 2016
@jbhurat
Copy link
Contributor Author

jbhurat commented Nov 6, 2016

@eparis, can you please review this PR when you get a chance. #31707 has been merged and #36079 has lgtm label and should be merged soon

@eparis
Copy link
Contributor

eparis commented Nov 7, 2016

@brendondburns I'm traveling until next week. Can't figure out how to reassign in the mobile UI...

@eparis
Copy link
Contributor

eparis commented Nov 7, 2016

@brendandburns

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 11, 2016
@apelisse apelisse removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 11, 2016
@dragon9783
Copy link

@jbhurat I have a question about launch kubelet on window, how can i configure kubelet output log to window Event Log, and i see that there is RedirectStandError flag in script, How can i redirect kubelet log to Event Log using this flag? thanks

@jbhurat
Copy link
Contributor Author

jbhurat commented Nov 22, 2016

@dragon9783 I don't think there is way the output logs be configured to log to Event Log, without having an intermediary process which would tail the log file and write to event log.

@dragon9783
Copy link

@jbhurat thank you

@jbhurat
Updated the script to use nssm service manager
3a8ba99 
Updated the script to use nssm service manager instead of Start-Process as it supports log rotation and auto restart of Services on host reboot
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit 3a8ba99. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@jbhurat
Copy link
Contributor Author

jbhurat commented Dec 5, 2016

@k8s-bot kops aws e2e test this

@xiaolou86
Copy link
Contributor

Can nssm limit the number of logfiles? That's mean, if the number exceeds N, the new log file will replace the oldest one.

@jbhurat
Copy link
Contributor Author

jbhurat commented Dec 6, 2016

@xiaolou86 I went through the documentation for nssm and I don't think it is possible to limit the number of log files.

@jbhurat
Fixed the issue with log rotation
a6f50e0 
Fixed the issue where log files where being rotated every 1mb instead of 1gb
@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE e2e failed for commit a6f50e0. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Dec 13, 2016
@eparis
Copy link
Contributor

eparis commented Jan 11, 2017

@k8s-bot test this

@eparis eparis assigned brendandburns and unassigned eparis Jan 11, 2017
@brendandburns
Copy link
Contributor

@k8s-bot cri e2e test this

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 920d8fd into kubernetes:master Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jbhurat @eparis @dragon9783 @k8s-ci-robot @xiaolou86 @brendandburns @k8s-github-robot @apelisse @googlebot