Add retry to node scheduability marking. #36211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
justinsb
added
lgtm
|
LGTM - thanks @brendandburns |
brendandburns
removed
the
lgtm
|
unmarking LGTM, as I realized I need to update ResourceVersion to "" every iteration... |
brendandburns
added
the
lgtm
|
re-LGTM, small change. |
mengqiy
reviewed
Nov 7, 2016
| } else { | ||
| break | ||
| } | ||
| // It's a race, no need to sleep |
There was a problem hiding this comment.
If we worry about that there may be a race. Why don't we use PATCH like edit and apply
|
Release-czar approved post-code freeze merge--This was LGTMed and in the merge-queue at code freeze time for 1.5. Adding 1.5 milestone to let it gets merged after code freeze. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32391
@justinsb @janetkuo @kubernetes/sig-cli
This change is