Add TypeAccessor to api/meta for objects without Object/ListMeta #3603
Conversation
| @@ -33,16 +33,14 @@ type VersionInterfaces struct { | |||
| // not support that field (Name, UID, Namespace on lists) will be a no-op and return | |||
| // a default value. | |||
| type Interface interface { | |||
There was a problem hiding this comment.
Should this become "ObjectInterface" ?
There was a problem hiding this comment.
Probably, although I think at the time it was added the intent was that you would primarily use Interface on the package, thus following the upstream convention. But now it's much more ObjectInterface than Interface.
----- Original Message -----
@@ -33,16 +33,14 @@ type VersionInterfaces struct {
// not support that field (Name, UID, Namespace on lists) will be a no-op
and return
// a default value.
type Interface interface {Should this become "ObjectInterface" ?
Reply to this email directly or view it on GitHub:
https://github.com/GoogleCloudPlatform/kubernetes/pull/3603/files#r23260815
There was a problem hiding this comment.
Toss in a TODO to rename it and I'll let you off the hook
There was a problem hiding this comment.
Done
----- Original Message -----
@@ -33,16 +33,14 @@ type VersionInterfaces struct {
// not support that field (Name, UID, Namespace on lists) will be a no-op
and return
// a default value.
type Interface interface {Toss in a TODO to rename it and I'll let you off the hook
Reply to this email directly or view it on GitHub:
https://github.com/GoogleCloudPlatform/kubernetes/pull/3603/files#r23262608
|
LGTM, one open question |
Adding objects that have TypeMeta (use runtime.Scheme) but do not expose ObjectMeta/ListMeta (because they are not Kube API objects) and wanted to get the simpler access path for in memory objects.
smarterclayton
force-pushed
the
expose_type_accessor
branch
from
20c645a to
5f6caab
Compare
Add TypeAccessor to api/meta for objects without Object/ListMeta
Adding objects that have TypeMeta (use runtime.Scheme) but do not
expose ObjectMeta/ListMeta (because they are not Kube API objects)
and wanted to get the simpler access path for in memory objects.
Updated pkg/api/serialization_test.go to use it.