Hide groups with new versions from old kubectl #35840

caesarxuchao · 2016-10-29T00:10:29Z

What caused the bug?

In 1.5, we are going to graduate Policy and Apps to beta. Old version kubectl doesn't has the new versions built-in, its TRP dynamic discover thinks Policy/v1beta1 is a TPR, and tried to register it in kubectl's scheme. The registration failed because Policy group already exist, because kubectl had registered Policy.v1alpha1.

How does this PR fix the bug?

This PR let the API server hides Policy and Apps from old version kubectl, so TPR discovery won't see them.

Old version kubectl doesn't know about Policy/v1beta1 or Apps/v1beta1, and v1alpha1 will be removed, so old version kubectl won't work for Policy or Apps anyway, so this PR does not cause any function loss.

@kubernetes/sig-api-machinery @liggitt @smarterclayton @deads2k @janetkuo @mwielgus

This change is

k8s-ci-robot · 2016-10-29T00:34:39Z

Jenkins GCE Node e2e failed for commit 03c281e. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

caesarxuchao · 2016-10-29T02:32:58Z

@k8s-bot node e2e test this

liggitt · 2016-10-29T02:52:42Z

pkg/genericapiserver/genericapiserver.go

@@ -429,6 +430,43 @@ func (s *GenericAPIServer) newAPIGroupVersion(apiGroupInfo *APIGroupInfo, groupV
 	}, nil
 }

+// TODO: Remove in 1.6. Returns if kubectl is older than v1.5.0
+func isOldKubectl(userAgent string) bool {


Not in genericapiserver, please. This only applies to the master, so make the surface area here as small as possible

caesarxuchao · 2016-10-29T21:39:17Z

Moved to apiserver. PTAL. Thanks.

k8s-ci-robot · 2016-10-29T21:58:42Z

Jenkins verification failed for commit 586a170. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

liggitt · 2016-10-29T21:46:00Z

pkg/apiserver/apiserver.go

 	"time"

+	"k8s.io/client-go/pkg/util/sets"
+	"k8s.io/client-go/pkg/version"


It's unfortunate goimports finds common types in the client-go pkg first. I think we want our own sets type

Same for the version util

Eh..I'm using goimports locally and I guess it imports based on alphabetical order.

I anticipate that creeping in a lot of places after client-go is added :-/

Yes. I think these kind of utility packages should be moved to their own repo, then there will be only one copy of them.

janetkuo · 2016-10-31T20:27:52Z

@liggitt @smarterclayton merging this PR will unblock two 1.5 PRs for moving StatefulSet to beta (#35731) and DisruptionBudget to beta (#35567)

liggitt · 2016-10-31T20:32:50Z

pkg/apiserver/apiserver.go

+
+// TODO: Remove in 1.6. This is for backward compatibility with 1.4 kubectl.
+// See https://github.com/kubernetes/kubernetes/issues/35791
+var groupsWithNewVersionsIn1_5 = sets.NewString("apps", "policy")


both of these groups existed in 1.4... we're completely hiding the groups from the discovery doc? won't that break old kubectl if someone tries to create anything in those groups?

The alpha version of the two groups will be removed in 1.5, so 1.4 kubectl won't work for these groups with an 1.5 apiserver anyway.

caesarxuchao · 2016-11-01T17:30:52Z

@smarterclayton @liggitt could you take a look? Thanks.

liggitt · 2016-11-01T19:19:24Z

seems ok. can you queue up the revert to merge once the 1.5 branch is cut?

caesarxuchao · 2016-11-01T20:56:36Z

Do you mean revert in 1.6?

liggitt · 2016-11-01T20:59:45Z

yes, which I guess is right after the 1.5 branch is done fast-forwarding master, right?

caesarxuchao · 2016-11-01T21:07:34Z

Right. Created #36004.

caesarxuchao · 2016-11-01T23:53:28Z

If there is no more comment I'll apply the label. It's blocking two 1.5 PRs.

janetkuo · 2016-11-02T00:58:39Z

If there is no more comment I'll apply the label. It's blocking two 1.5 PRs.

Yes, presumably those PRs block other 1.5 PRs also. Would love to see this one merged ASAP.

k8s-github-robot · 2016-11-02T11:49:56Z

Automatic merge from submit-queue

lavalamp · 2016-12-06T21:39:01Z

IMO this is a client bug. I guess changing the server is an OK temporary fix, but the client should also change to tolerate collisions like this, so that we don't ever need any more server bandaids.

caesarxuchao · 2016-12-06T21:41:24Z

#36898 is the client-side fix. It's merged.

lavalamp · 2016-12-06T21:42:45Z

Oh, awesome!

deads2k · 2016-12-06T21:52:44Z

I agree. I fixed it client-side shortly before release.

…

On Tue, Dec 6, 2016 at 4:39 PM, Daniel Smith ***@***.***> wrote: IMO this is a client bug. I guess changing the server is an OK temporary fix, but the client should also change to tolerate collisions like this, so that we don't ever need any more server bandaids. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35840 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH2BSp324rsT8T01qZSWQFlnnrzeofciks5rFdYOgaJpZM4Kj9_p> .

@liggitt

Automatic merge from submit-queue (batch tested with PRs 39114, 36004) Revert #32751 and #35840 in 1.6 Revert backward compatibility hacks (#36004, #32751) that are no-longer needed in release 1.6 @kubernetes/sig-api-machinery @liggitt

caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 29, 2016

caesarxuchao added this to the v1.5 milestone Oct 29, 2016

googlebot added the cla: yes label Oct 29, 2016

k8s-github-robot assigned lavalamp Oct 29, 2016

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Oct 29, 2016

caesarxuchao assigned smarterclayton and unassigned lavalamp Oct 29, 2016

liggitt reviewed Oct 29, 2016

View reviewed changes

caesarxuchao force-pushed the hide-new-versions branch from 03c281e to 586a170 Compare October 29, 2016 21:34

caesarxuchao mentioned this pull request Oct 29, 2016

Old kubectl crashes when v1alpha1 api is replaced with v1beta1. #35791

Closed

liggitt reviewed Oct 29, 2016

View reviewed changes

add group filter

a545ac7

caesarxuchao force-pushed the hide-new-versions branch from 586a170 to a545ac7 Compare October 29, 2016 22:05

caesarxuchao added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 29, 2016

janetkuo mentioned this pull request Oct 31, 2016

Move Statefulset (previously PetSet) to v1beta1 #35731

Merged

liggitt reviewed Oct 31, 2016

View reviewed changes

caesarxuchao pushed a commit to caesarxuchao/kubernetes that referenced this pull request Nov 1, 2016

revert kubernetes#35840 in 1.6

f1f6d99

caesarxuchao mentioned this pull request Nov 1, 2016

Revert #32751 and #35840 in 1.6 #36004

Merged

smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2016

mwielgus added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 2, 2016

k8s-github-robot merged commit 5774ca1 into kubernetes:master Nov 2, 2016

enisoc mentioned this pull request Dec 2, 2016

Helm 2.0.0 does not support StatefulSet helm/helm#1581

Closed

caesarxuchao mentioned this pull request Dec 21, 2016

Add a custom user-agent header #39106

Closed

liggitt mentioned this pull request Mar 2, 2017

kubectl built from head does not recognize all api versions with older server version #40813

Closed

caesarxuchao mentioned this pull request Mar 6, 2017

Tighten kubectl version check #42600

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide groups with new versions from old kubectl #35840

Hide groups with new versions from old kubectl #35840

caesarxuchao commented Oct 29, 2016 •

edited by janetkuo

Loading

k8s-ci-robot commented Oct 29, 2016

caesarxuchao commented Oct 29, 2016

liggitt Oct 29, 2016

caesarxuchao commented Oct 29, 2016

k8s-ci-robot commented Oct 29, 2016

liggitt Oct 29, 2016

liggitt Oct 29, 2016

caesarxuchao Oct 29, 2016

caesarxuchao Oct 29, 2016

liggitt Oct 29, 2016

caesarxuchao Oct 29, 2016

janetkuo commented Oct 31, 2016

liggitt Oct 31, 2016 •

edited

Loading

caesarxuchao Oct 31, 2016 •

edited

Loading

caesarxuchao commented Nov 1, 2016

liggitt commented Nov 1, 2016

caesarxuchao commented Nov 1, 2016

liggitt commented Nov 1, 2016 •

edited

Loading

caesarxuchao commented Nov 1, 2016

caesarxuchao commented Nov 1, 2016

janetkuo commented Nov 2, 2016

k8s-github-robot commented Nov 2, 2016

lavalamp commented Dec 6, 2016

caesarxuchao commented Dec 6, 2016

lavalamp commented Dec 6, 2016

deads2k commented Dec 6, 2016 via email

Hide groups with new versions from old kubectl #35840

Hide groups with new versions from old kubectl #35840

Conversation

caesarxuchao commented Oct 29, 2016 • edited by janetkuo Loading

k8s-ci-robot commented Oct 29, 2016

caesarxuchao commented Oct 29, 2016

liggitt Oct 29, 2016

Choose a reason for hiding this comment

caesarxuchao commented Oct 29, 2016

k8s-ci-robot commented Oct 29, 2016

liggitt Oct 29, 2016

Choose a reason for hiding this comment

liggitt Oct 29, 2016

Choose a reason for hiding this comment

caesarxuchao Oct 29, 2016

Choose a reason for hiding this comment

caesarxuchao Oct 29, 2016

Choose a reason for hiding this comment

liggitt Oct 29, 2016

Choose a reason for hiding this comment

caesarxuchao Oct 29, 2016

Choose a reason for hiding this comment

janetkuo commented Oct 31, 2016

liggitt Oct 31, 2016 • edited Loading

Choose a reason for hiding this comment

caesarxuchao Oct 31, 2016 • edited Loading

Choose a reason for hiding this comment

caesarxuchao commented Nov 1, 2016

liggitt commented Nov 1, 2016

caesarxuchao commented Nov 1, 2016

liggitt commented Nov 1, 2016 • edited Loading

caesarxuchao commented Nov 1, 2016

caesarxuchao commented Nov 1, 2016

janetkuo commented Nov 2, 2016

k8s-github-robot commented Nov 2, 2016

lavalamp commented Dec 6, 2016

caesarxuchao commented Dec 6, 2016

lavalamp commented Dec 6, 2016

deads2k commented Dec 6, 2016 via email

caesarxuchao commented Oct 29, 2016 •

edited by janetkuo

Loading

liggitt Oct 31, 2016 •

edited

Loading

caesarxuchao Oct 31, 2016 •

edited

Loading

liggitt commented Nov 1, 2016 •

edited

Loading