Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop including arch-specific binaries in kubernetes.tar.gz #35737

Merged
merged 1 commit into from
Oct 28, 2016
Merged

Stop including arch-specific binaries in kubernetes.tar.gz #35737

merged 1 commit into from
Oct 28, 2016

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Oct 27, 2016 •
edited
Loading

What this PR does / why we need it:
This PR stops including the kubernetes client and server tarballs in kubernetes.tar.gz. These should instead be downloaded separately for only the required architectures.

The cluster/get-kube.sh (https://get.k8s.io) and cluster/get-kube-binaries.sh handle downloading and extracting the necessary binaries for you automatically. Jenkins also uses this workflow now.

Anyone still expecting binaries in kubernetes.tar.gz will be broken, but I've at least fixed all occurrences in-tree.

Which issue this PR fixes: fixes #28629, chips away at #28435

Release note:

Arch-specific server and client binaries are no longer included in `kubernetes.tar.gz`. You must manually download the necessary architecture-specific tarballs or use `kubernetes/cluster/get-kube-binaries.sh` to download them for you.

cc @luxas @zmerlynn @justinsb @mikedanese @thockin @spxtr

This change is Reviewable

@ixdy ixdy added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 27, 2016
@ixdy ixdy added this to the v1.5 milestone Oct 27, 2016
@ixdy ixdy force-pushed the remove-arch-binaries-from-kubernetes-full-tarball branch from 7978b4a to 6d2b25f Compare October 27, 2016 23:01
@david-mcmahon david-mcmahon added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2016
@ixdy
Copy link
Member Author

ixdy commented Oct 27, 2016

For comparison:

$ gsutil ls -lh gs://kubernetes-release-dev/ci-cross/v1.5.0-alpha.1.1025+cfdaf18277e1eb/kubernetes.tar.gz
839.87 MiB  2016-10-27T06:41:49Z  gs://kubernetes-release-dev/ci-cross/v1.5.0-alpha.1.1025+cfdaf18277e1eb/kubernetes.tar.gz
$ gsutil ls -lh gs://kubernetes-release-dev/ci/v1.4.5-beta.0.47+833455c19472f7/kubernetes.tar.gz
  1.01 GiB  2016-10-27T22:56:26Z  gs://kubernetes-release-dev/ci/v1.4.5-beta.0.47+833455c19472f7/kubernetes.tar.gz
$ du -sh _output/release-tars/kubernetes.tar.gz 
4.6M    _output/release-tars/kubernetes.tar.gz

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 6d2b25fb3f42a9860a4d26deb148ac7f47786086. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 6d2b25fb3f42a9860a4d26deb148ac7f47786086. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ixdy ixdy force-pushed the remove-arch-binaries-from-kubernetes-full-tarball branch from 6d2b25f to 8ab452c Compare October 27, 2016 23:24
@ixdy
Copy link
Member Author

ixdy commented Oct 27, 2016

yeah, yeah.

tar: /var/lib/jenkins/workspace/pull-kubernetes-e2e-gke-gci/go/src/k8s.io/kubernetes/_output/release-stage/full/kubernetes/cluster/gce: Cannot open: No such file or directory

Changing /final/ back to /full/, even though this isn't really "full" anymore.

@ixdy
Copy link
Member Author

ixdy commented Oct 27, 2016

Announcement posted on kubernetes-dev.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2016
@david-mcmahon
Copy link
Contributor

Still /lgtm.

@david-mcmahon david-mcmahon added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2016
@luxas
Copy link
Member

luxas commented Oct 28, 2016

As long as this doesn't break GCS paths, I'm OK with it.
Never used the tarballs anyway :)

@ixdy
Copy link
Member Author

ixdy commented Oct 28, 2016

@luxas yep, the only thing changing is kubernetes.tar.gz.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 8ab452c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit bc7ae39 into kubernetes:master Oct 28, 2016
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@spiffxp spiffxp mentioned this pull request Dec 15, 2016
Closed
@ixdy ixdy deleted the remove-arch-binaries-from-kubernetes-full-tarball branch May 15, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@david-mcmahon david-mcmahon

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Build release tars per-architecture
7 participants
@ixdy @k8s-ci-robot @david-mcmahon @luxas @k8s-github-robot @jbeda @googlebot