Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Statefulset (previously PetSet) to v1beta1 #35731

Merged
merged 3 commits into from
Nov 3, 2016
Merged

Move Statefulset (previously PetSet) to v1beta1 #35731

merged 3 commits into from
Nov 3, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Oct 27, 2016 •
edited by erictune
Loading

What this PR does / why we need it: #28718

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer: depends on #35663 (PetSet rename)
cc @erictune @foxish @kubernetes/sig-apps

Release note:

v1beta1/StatefulSet replaces v1alpha1/PetSet.

This change is Reviewable

@janetkuo janetkuo mentioned this pull request Oct 27, 2016
Closed
@erictune erictune mentioned this pull request Oct 27, 2016
Closed
smarterclayton
smarterclayton reviewed Oct 27, 2016
View reviewed changes
pkg/client/clientset_generated/release_1_4/typed/apps/v1alpha1/apps_client.go
@@ -25,18 +25,13 @@ import (

type AppsInterface interface {
GetRESTClient() *restclient.RESTClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caesarxuchao will this break the client-go 1.4 staging when we do this (hoping no, but want to be absolutely sure)? Would obviously not want to break the 1.4 branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it won't. We stop publishing 1.4 client-go. I'll remove the release_1_4 folder entirely soon.

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 27, 2016
@janetkuo janetkuo added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Oct 27, 2016
@janetkuo janetkuo mentioned this pull request Oct 27, 2016
Closed
11 tasks
@janetkuo janetkuo added this to the v1.5 milestone Oct 27, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2016
@janetkuo janetkuo force-pushed the statefulset-v1beta1 branch from 5705d15 to 765bc9f Compare October 28, 2016 04:05
@janetkuo janetkuo removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2016
@chrislovecnm
Copy link
Contributor

@k8s-bot cvm gke e2e test this

@janetkuo
Copy link
Member Author

@k8s-bot kubemark e2e test this

@janetkuo
Copy link
Member Author

@k8s-bot cvm gce e2e test this

@janetkuo
Copy link
Member Author

@k8s-bot gce etcd3 e2e test this

@janetkuo
Copy link
Member Author

@k8s-bot gci gce e2e test this

@jimmycuadra jimmycuadra mentioned this pull request Oct 28, 2016
Merged
@janetkuo
Copy link
Member Author

@k8s-bot kubemark e2e test this
@k8s-bot gci gce e2e test this
@k8s-bot gce etcd3 e2e test this
@k8s-bot cvm gce e2e test this

@janetkuo
Copy link
Member Author

janetkuo commented Oct 28, 2016 •
edited
Loading

Not sure why these 4 tests keep failing to build....

Jenkins GCE e2e — Build failed.
Jenkins GCE etcd3 e2e — Build failed.
Jenkins GCI GCE e2e — Build failed.
Jenkins Kubemark GCE e2e — Build failed.

@janetkuo janetkuo force-pushed the statefulset-v1beta1 branch from 765bc9f to e1d14de Compare October 28, 2016 20:07
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit e1d14de0cdd5b709184b9463d258ecd8eb36f652. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@caesarxuchao caesarxuchao mentioned this pull request Oct 28, 2016
Closed
@janetkuo
Copy link
Member Author

janetkuo commented Oct 28, 2016 •
edited
Loading

Not sure why these 4 tests keep failing to build....

So these test failures are because of these errors found in addon-manager logs:

error: group map[autoscaling:0xc82031df80 certificates.k8s.io:0xc8203d01c0 extensions:0xc8203d0310 policy:0xc8203d0380 storage.k8s.io:0xc8203d0460 apps:0xc82031dd50 authorization.k8s.io:0xc82031df10 authentication.k8s.io:0xc8203
1ddc0 batch:0xc8203d0150 componentconfig:0xc8203d0230 rbac.authorization.k8s.io:0xc8203d03f0 federation:0xc82031d810 :0xc82031dce0] is already registered
error: group map[federation:0xc820327810 authentication.k8s.io:0xc820327dc0 autoscaling:0xc820327f80 componentconfig:0xc8203da230 storage.k8s.io:0xc8203da460 policy:0xc8203da380 rbac.authorization.k8s.io:0xc8203da3f0 :0xc820327c
e0 apps:0xc820327d50 authorization.k8s.io:0xc820327f10 batch:0xc8203da150 certificates.k8s.io:0xc8203da1c0 extensions:0xc8203da310] is already registered
error: group map[federation:0xc820323810 autoscaling:0xc820323f80 componentconfig:0xc8203d8230 rbac.authorization.k8s.io:0xc8203d83f0 extensions:0xc8203d8310 policy:0xc8203d8380 :0xc820323ce0 apps:0xc820323d50 authentication.k8s
.io:0xc820323dc0 authorization.k8s.io:0xc820323f10 batch:0xc8203d8150 certificates.k8s.io:0xc8203d81c0 storage.k8s.io:0xc8203d8460] is already registered
error: group map[federation:0xc820325810 :0xc820325ce0 authentication.k8s.io:0xc820325dc0 autoscaling:0xc820325f80 batch:0xc8203d6150 policy:0xc8203d6380 apps:0xc820325d50 authorization.k8s.io:0xc820325f10 certificates.k8s.io:0x
c8203d61c0 componentconfig:0xc8203d6230 extensions:0xc8203d6310 rbac.authorization.k8s.io:0xc8203d63f0 storage.k8s.io:0xc8203d6460] is already registered
error: group map[certificates.k8s.io:0xc8203d61c0 componentconfig:0xc8203d6230 extensions:0xc8203d6310 policy:0xc8203d6380 federation:0xc820325810 :0xc820325ce0 authorization.k8s.io:0xc820325f10 batch:0xc8203d6150 rbac.authoriza
tion.k8s.io:0xc8203d63f0 storage.k8s.io:0xc8203d6460 apps:0xc820325d50 authentication.k8s.io:0xc820325dc0 autoscaling:0xc820325f80] is already registered
error: group map[rbac.authorization.k8s.io:0xc8203d83f0 apps:0xc820325d50 authorization.k8s.io:0xc820325f10 autoscaling:0xc820325f80 batch:0xc8203d8150 certificates.k8s.io:0xc8203d81c0 extensions:0xc8203d8310 policy:0xc8203d8380
 federation:0xc820325810 :0xc820325ce0 authentication.k8s.io:0xc820325dc0 componentconfig:0xc8203d8230 storage.k8s.io:0xc8203d8460] is already registered

ref #35791, it's likely due to third-party resource discovery code:

TPR discovery code that is trying to identify TPR versions and hacks them into the list of registered APIs.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2016
@erictune
Copy link
Member

erictune commented Nov 2, 2016

Ready to rebase.

@janetkuo janetkuo removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 2, 2016
@janetkuo janetkuo force-pushed the statefulset-v1beta1 branch from 024b389 to 1c78e49 Compare November 2, 2016 18:00
@janetkuo janetkuo added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2016
@janetkuo
Copy link
Member Author

janetkuo commented Nov 2, 2016

Bumping priority since it's been rebased for several times and it's release blocking and it's blocked by other PR for several days.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2016
@janetkuo janetkuo force-pushed the statefulset-v1beta1 branch from 1c78e49 to 9203cce Compare November 2, 2016 21:11
@janetkuo janetkuo added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 9203cce1604c338e471319ab60a75de194b4f0db. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@janetkuo
Copy link
Member Author

janetkuo commented Nov 2, 2016

@k8s-bot gci gke e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 9203cce1604c338e471319ab60a75de194b4f0db. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@janetkuo
Replace apps/v1alpha1 with apps/v1beta1 and manually remove generated…
c15b947 
… apps/v1alpha1 files

Manually remove generated apps/v1alpha1 types, protobuf, and api-reference doc files
Manually remove apps/v1alpha1 folder from 1.5 generated client
@janetkuo
Remove 'stateful set is alpha' comment in types.go
2a43ddc
@janetkuo
(Auto-gen) Run hack/update-all & update-bazel & update linted packages
c25455e
@janetkuo janetkuo force-pushed the statefulset-v1beta1 branch from 9203cce to c25455e Compare November 2, 2016 22:17
@janetkuo janetkuo added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 2, 2016
@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 3, 2016 •
edited
Loading

@janetkuo when we merging this?? Code freeze is soon. Love to see this in sooner than later.

@janetkuo
Copy link
Member Author

janetkuo commented Nov 3, 2016

@chrislovecnm hopefully today. Submit queue is blocked now 😢

@chrislovecnm
Copy link
Contributor

SGTM /facepalm

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e817594 into kubernetes:master Nov 3, 2016
k8s-github-robot pushed a commit that referenced this pull request Nov 4, 2016
Merge pull request #36018 from janetkuo/statefulset-beta-test
4261598 
Automatic merge from submit-queue

Remove statefulset e2e test setup for alpha

Depends on #35731, once statefulset is beta, it doesn't need special treatment for alpha version in e2e test 

cc @erictune @foxish @kubernetes/sig-apps
k8s-github-robot pushed a commit that referenced this pull request Nov 6, 2016
Merge pull request #35776 from jimmycuadra/petset-rename-docs-examples
b75c3a4 
Automatic merge from submit-queue

Rename PetSet to StatefulSet in docs and examples.

**What this PR does / why we need it**: Addresses some of the pre-code-freeze changes for implementing the PetSet --> StatefulSet rename. (#35534)

**Special notes for your reviewer**: This PR only changes docs and examples, as #35731 hasn't been merged yet and I don't want to create merge conflicts. I'll open another PR for any remaining code changes needed after that PR is merged. /cc @erictune @janetkuo @chrislovecnm
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@smarterclayton smarterclayton smarterclayton left review comments

Assignees

@foxish foxish

@erictune erictune

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
9 participants
@janetkuo @chrislovecnm @k8s-ci-robot @erictune @smarterclayton @caesarxuchao @k8s-github-robot @foxish @googlebot