Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ie." is not the correct abbreviation for "ID EST" #35674

Merged
merged 1 commit into from
Oct 28, 2016
Merged

"ie." is not the correct abbreviation for "ID EST" #35674

merged 1 commit into from
Oct 28, 2016
+2 −2

Conversation

YuPengZTE
Copy link
Contributor

@YuPengZTE YuPengZTE commented Oct 27, 2016 •
edited by k8s-oncall
Loading

What this PR does / why we need it:
"i.e." is the correct abbreviation for "ID EST"

Signed-off-by: yupeng yu.peng36@zte.com.cn

This change is Reviewable

@YuPengZTE
ie. is not the correct abbreviation for ID EST
746dd4d 
Signed-off-by: yupeng <yu.peng36@zte.com.cn>
@k8s-ci-robot
Copy link
Contributor

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-github-robot k8s-github-robot added kind/design Categorizes issue or PR as related to design. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Oct 27, 2016
@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 28, 2016
@brendandburns
Copy link
Contributor

LGTM, thanks for the PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 746dd4d. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 746dd4d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2ff7e26 into kubernetes:master Oct 28, 2016
@YuPengZTE YuPengZTE deleted the devIE branch November 1, 2016 00:57
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
Merge pull request kubernetes#35674 from YuPengZTE/devIE
497b26f 
Automatic merge from submit-queue

"ie." is not the correct abbreviation for "ID EST"

**What this PR does / why we need it**:
"i.e." is the correct abbreviation for "ID EST"

Signed-off-by: yupeng <yu.peng36@zte.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YuPengZTE @k8s-ci-robot @brendandburns @k8s-github-robot @googlebot