Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a retry when reading a file content from a container #35560

Merged
merged 1 commit into from
Oct 29, 2016
Merged

Add a retry when reading a file content from a container #35560

merged 1 commit into from
Oct 29, 2016
+19 −10

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Oct 25, 2016 •
edited by jessfraz
Loading

To avoid temporal failure in reading the file content, add a retry
process in function verifyPDContentsViaContainer

Add a retry when reading a file content from a container

This change is Reviewable

@jingxu97
Add a retry when reading a file content from a container
837fde7 
To avoid temporal failure in reading the file content, add a retry
process in function verifyPDContentsViaContainer
@jingxu97
Copy link
Contributor Author

jingxu97 commented Oct 25, 2016 •
edited
Loading

@saad-ali PTAL

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Oct 25, 2016
@saad-ali
Copy link
Member

For reference this is a follow-up to PR #34570

@saad-ali
Copy link
Member

@jingxu97 Can you confirm all Pod disk... tests pass with this PR?

@saad-ali
Copy link
Member

Ping

@jingxu97
Copy link
Contributor Author

@saad-ali , I tested for about 4 hours, so far it is passing.

@saad-ali
Copy link
Member

Great, thanks Jing!

LGTM

@saad-ali saad-ali added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 28, 2016
@jingxu97 jingxu97 added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 28, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2f4cdd3 into kubernetes:master Oct 29, 2016
@saad-ali saad-ali added this to the v1.4 milestone Nov 1, 2016
@saad-ali
Copy link
Member

saad-ali commented Nov 1, 2016

Please cherry pick to 1.4 to fix flakes in 1.4 branch

This was referenced Nov 4, 2016
Closed
Closed
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 8, 2016
Merge pull request #36398 from saad-ali/automated-cherry-pick-of-#33976-
f9a5a40 
#35560-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #33976 #35560 upstream release 1.4

Cherry pick PRs #33976 and #35560 on behalf of @jingxu97 to 1.4 branch to fix `Pod disks...` flakes.
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. labels Nov 9, 2016
@saad-ali saad-ali mentioned this pull request Nov 10, 2016
Closed
@saad-ali saad-ali mentioned this pull request Nov 17, 2016
Closed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#36398 from saad-ali/automated-cherry-pi…
201ba25 
…ck-of-#33976-kubernetes#35560-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#33976 kubernetes#35560 upstream release 1.4

Cherry pick PRs kubernetes#33976 and kubernetes#35560 on behalf of @jingxu97 to 1.4 branch to fix `Pod disks...` flakes.
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jingxu97 @saad-ali @k8s-github-robot @jessfraz @googlebot