Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #28922 #29892 #30182 #31025 #32013 #32235 #34359 #35233 #35459

Merged
merged 8 commits into from
Oct 25, 2016
Merged

Automated cherry pick of #28922 #29892 #30182 #31025 #32013 #32235 #34359 #35233 #35459

merged 8 commits into from
Oct 25, 2016

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Oct 24, 2016 •
edited by k8s-oncall
Loading

Cherry pick of #28922 #29892 #30182 #31025 #32013 #32235 #34359 #35233 on release-1.2.
#28922: Add RELEASE_INFRA_PUSH related code to support pushes from
#29892: Clone kubernetes/release into something other than /release
#30182: Add SET_NOMOCK_FLAG handling.
#31025: Fix unbound variable issue (set -e).
#32013: Call push-ci-build.sh from the kubernetes/release repo.
#32235: Change push-ci-build.sh to push-build.sh and some cleanup.
#34359: Add support for adding a suffix to the GCS upload dir in
#35233: Delete some old, dead release code

This change is Reviewable

@ixdy
Copy link
Member Author

ixdy commented Oct 24, 2016

cc @fejta @david-mcmahon

This is the version of #35458 for release-1.2.

I'm guessing we don't care about release-1.1 or earlier? I don't see it on Jenkins.

@ixdy ixdy added cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. labels Oct 24, 2016
@ixdy ixdy added this to the v1.2 milestone Oct 24, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 6e5aa1c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 6e5aa1c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2016
@ixdy
Copy link
Member Author

ixdy commented Oct 24, 2016

oh right, I think PR GKE has always been broken on release-1.2 because we don't have build/util.sh in this branch. It's not easy to cherry-pick, but I could manually just copy it in here if we think it'd be appropriate.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 6e5aa1c. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 6e5aa1c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ixdy ixdy mentioned this pull request Oct 25, 2016
Merged
@roberthbailey roberthbailey added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Oct 25, 2016
@roberthbailey roberthbailey merged commit 3d5d1aa into kubernetes:release-1.2 Oct 25, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@ixdy ixdy deleted the automated-cherry-pick-of-#28922-#29892-#30182-#31025-#32013-#32235-#34359-#35233-upstream-release-1.2 branch October 25, 2016 03:46
@ixdy ixdy mentioned this pull request Oct 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maisem maisem

@roberthbailey roberthbailey

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
8 participants
@ixdy @k8s-ci-robot @k8s-github-robot @k8s-cherrypick-bot @maisem @googlebot @roberthbailey @david-mcmahon