Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vSphere Kube-up: resolve vm-names on all nodes. #35365

Merged
merged 1 commit into from
Oct 24, 2016
Merged

vSphere Kube-up: resolve vm-names on all nodes. #35365

merged 1 commit into from
Oct 24, 2016

Conversation

kerneltime
Copy link

@kerneltime kerneltime commented Oct 22, 2016 •
edited by jessfraz
Loading

What this PR does / why we need it:
This addresses the #35364

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #35364
Special notes for your reviewer:
Will cherry pick to release-1.4

vSphere Kube-up: resolve vm-names on all nodes

This change is Reviewable

vSphere Kube-up: resolve vm-names on all nodes.
14cd178 
vm-names are used for vSphere cloud provider and they need to
resolution for log collection to work.
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Oct 22, 2016
@kerneltime kerneltime mentioned this pull request Oct 22, 2016
Merged
@kerneltime
Copy link
Author

Other than the issue being fixed there is no need for release-node-label-needed.

@eparis eparis added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 24, 2016
@eparis
Copy link
Contributor

eparis commented Oct 24, 2016

Do we do this on any other cloud providers? Or do we just expect that to be part of the infrastructure for things like GCE and AWS?

@eparis eparis added lgtm "Looks good to me", indicates that a PR is ready to be merged. retest-not-required labels Oct 24, 2016
@kerneltime
Copy link
Author

kerneltime commented Oct 24, 2016 •
edited
Loading

A lot of other deployments use IP address directly when nodes connect to master(using host override), the current implementation of vSphere Cloud Provider needs vm-names and we need this PR to resolve the vm-names to ip when dashboard retrieves logs.

Since kube-up is designed to be deployed on any kind of vSphere deployment, the VM ip addresses are discovered and the mapping information needs to be propagated.

Without this PR in 1.4 branch and master, any communication that is node to node fails and it includes getting logs in dashboard. This is not the same as pod to pod communication.

We are looking into changing how vSphere Cloud Provider manages vm-names and IPs and how we setup the nodes (support for kube-anywhere) but those changes will be further down the road and aimed at 1.5.

@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 24, 2016
@jessfraz jessfraz added this to the v1.4 milestone Oct 24, 2016
@jessfraz jessfraz added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Oct 24, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c3d104a into kubernetes:master Oct 24, 2016
@kerneltime kerneltime deleted the fix-vm-name-resolv.kerneltime branch October 24, 2016 21:06
k8s-github-robot pushed a commit that referenced this pull request Oct 25, 2016
Merge pull request #35366 from vmware/automated-cherry-pick-of-#35365…
badcd72 
…-upstream-release-1.4

Automatic merge from submit-queue

vSphere Kube-up: resolve vm-names on all nodes.

Automated cherry-pick of #35365
fixes #35364
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#35366 from vmware/automated-cherry-pick…
bd0278d 
…-of-#35365-upstream-release-1.4

Automatic merge from submit-queue

vSphere Kube-up: resolve vm-names on all nodes.

Automated cherry-pick of kubernetes#35365
fixes kubernetes#35364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eparis eparis

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

vSphere kube-up: Dashboard does not collect logs
5 participants
@kerneltime @eparis @k8s-github-robot @jessfraz @googlebot