Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding rkt binary to GCI #35321

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Adding rkt binary to GCI #35321

merged 2 commits into from
Oct 25, 2016

Conversation

vishh
Copy link
Contributor

@vishh vishh commented Oct 21, 2016 •
edited by jessfraz
Loading

rkt is being used to support containerized storage plugins on GCI.

Added rkt binary to GCI

This change is Reviewable

@vishh vishh added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 21, 2016
@vishh vishh added this to the v1.4 milestone Oct 21, 2016
@vishh vishh added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Oct 21, 2016
@vishh
Copy link
Contributor Author

vishh commented Oct 21, 2016

Running manual tests now

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Oct 21, 2016
@vishh vishh added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 21, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 228438ba0e52f912a9880902f413005d51cc3c92. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@vishh
Copy link
Contributor Author

vishh commented Oct 21, 2016

@k8s-bot test this

@dchen1107 dchen1107 assigned dchen1107 and unassigned mtaufen Oct 21, 2016
@mtaufen mtaufen mentioned this pull request Oct 24, 2016
Merged
mtaufen
mtaufen reviewed Oct 24, 2016
View reviewed changes
cluster/gce/gci/configure.sh
@@ -98,6 +98,15 @@ function split-commas {
echo $1 | tr "," "\n"
}

function install-rkt {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a way to install rkt for e2e node tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Update node e2e testing manifest to install rkt on GCI nodes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

vishh added 2 commits October 25, 2016 12:38
@vishh
Adding rkt binary to GCI nodes via cloud-init.
bbc8183 
This is required for mounting storage volumes via containers.

Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh
add rkt to GCI node e2e test images
968e7eb 
Signed-off-by: Vishnu kannan <vishnuk@google.com>
@vishh vishh removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Oct 25, 2016
@mtaufen
Copy link
Contributor

mtaufen commented Oct 25, 2016

LGTM

@mtaufen mtaufen added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@jessfraz jessfraz added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 25, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit ffeb01f into kubernetes:master Oct 25, 2016
@jessfraz jessfraz mentioned this pull request Oct 26, 2016
Merged
@jessfraz
Copy link
Contributor

cherrypicked in #35653

@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 26, 2016
k8s-github-robot pushed a commit that referenced this pull request Oct 28, 2016
Merge pull request #35653 from jessfraz/automated-cherry-pick-of-#34368-
70f0b5a 
#35158-#35321-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #34368 #35158 #35321

Cherry pick of #34368 #35158 #35321 on release-1.4.

#34368: Node status updater should SetNodeStatusUpdateNeeded if it
#35158: Fixing flake caused by lack of polling during read.
#35321: Adding rkt binary to GCI nodes via cloud-init. This is
@jessfraz jessfraz mentioned this pull request Nov 17, 2016
Closed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#35653 from jessfraz/automated-cherry-pi…
a884b16 
…ck-of-#34368-kubernetes#35158-kubernetes#35321-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#34368 kubernetes#35158 kubernetes#35321

Cherry pick of kubernetes#34368 kubernetes#35158 kubernetes#35321 on release-1.4.

kubernetes#34368: Node status updater should SetNodeStatusUpdateNeeded if it
kubernetes#35158: Fixing flake caused by lack of polling during read.
kubernetes#35321: Adding rkt binary to GCI nodes via cloud-init. This is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen mtaufen left review comments

Assignees

@mtaufen mtaufen

@dchen1107 dchen1107

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@vishh @k8s-ci-robot @mtaufen @k8s-github-robot @jessfraz @googlebot @dchen1107