Automated cherry pick of #31189 #31704 #32831 #32907 #33003 #33349 #31190 #33581 #34089 #34234 #32822 #33393 #34246 #34435 #32477 upstream release 1.4 #35205
Conversation
- Error from Decorator will be returned instead of assuming false filtering - For List, Decorator is called on return list object - For Watch, we implement a new watcher to pipe through decorator
This reverts commit 9dcef2e.
…egration we had discovered we were leaking connections
Since kubernetes#33393 is merged, the bug should have been fixed.
wojtek-t
added
cherrypick-candidate
release-note-none
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
k8s-github-robot
added
do-not-merge
|
we are going to do this one in it's own release right? so we should wait to merge |
|
OK - all tests are passing now; @mml @timothysc @jessfraz - can you please take a look? |
|
these are the bits for etcd that can be merged now? |
jessfraz
added
the
cherry-pick-approved
Yes - this should not affect production at all (this is updating only Godeps for etcd (which are used only in tests) and etcd3 code (which is not used in 1.4 release). |
|
thanks for confirming! I'll let @mml and @timothysc do the honors but looks good to me |
jessfraz
removed
the
do-not-merge
|
Not sure exactly what a cherrypick code review should entail. The original code was carefully reviewed. Without reading all 17 PRs, all I can say is that the tests pass, so LGTM. |
jessfraz
added
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
wojtek-t
deleted the
automated-cherry-pick-of-#31189-#31704-#32831-#32907-#33003-#33349-#31190-#33581-#34089-#34234-#32822-#33393-#34246-#34435-#32477-upstream-release-1.4
branch
…ck-of-#31189-kubernetes#31704-kubernetes#32831-kubernetes#32907-kubernetes#33003-kubernetes#33349-kubernetes#31190-kubernetes#33581-kubernetes#34089-kubernetes#34234-kubernetes#32822-kubernetes#33393-kubernetes#34246-kubernetes#34435-kubernetes#32477-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#31189 kubernetes#31704 kubernetes#32831 kubernetes#32907 kubernetes#33003 kubernetes#33349 kubernetes#31190 kubernetes#33581 kubernetes#34089 kubernetes#34234 kubernetes#32822 kubernetes#33393 kubernetes#34246 kubernetes#34435 kubernetes#32477 upstream release 1.4 We are going to release etcd v3 in 1.4.x release. ``` Cherrypick etcd v3-related bug fixes to 1.4 branch ``` Those PRs include: - Updates of etcd Godeps - Update to pkg/storage/etcd directory - Two PR that were unnecessary to avoid conflicts: kubernetes#31189 kubernetes#31704 Automated cherry pick of kubernetes#31189 kubernetes#31704 kubernetes#32831 kubernetes#32907 kubernetes#33003 kubernetes#33349 kubernetes#31190 kubernetes#33581 kubernetes#34089 kubernetes#34234 kubernetes#32822 kubernetes#33393 kubernetes#34246 kubernetes#34435 kubernetes#32477 @hongchaodeng @xiang90 @lavalamp @smarterclayton
We are going to release etcd v3 in 1.4.x release.
Those PRs include:
Automated cherry pick of #31189 #31704 #32831 #32907 #33003 #33349 #31190 #33581 #34089 #34234 #32822 #33393 #34246 #34435 #32477
@hongchaodeng @xiang90 @lavalamp @smarterclayton
This change is