@dashpole can you add a test case that evicts based on inodes similar to the other test cases that work on disk?

yes, the test is going out in a seperate PR #33955. I will be testing 3 pods: one creates empty files in it's container, one creates empty files in an emptydir volume, and another creates one, large file. The eviction manager should hit inodepressure and evict both of the containers making empty files. I still need to look into making the test skip the "empty files in container" pod when using devicemapper. I also want to run the test more, to make sure it isnt flaky before adding the test.

@dashpole -- the e2e test is good, but we should also be able to mock the test in unit testing as well via something like the following: https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/eviction/eviction_manager_test.go#L315

@derekwaynecarr ill add a unit test to this PR

Jenkins GCE etcd3 e2e failed for commit c4652055208f3751baa41dd69c0139a8ca49194d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins GCI GCE e2e failed for commit c4652055208f3751baa41dd69c0139a8ca49194d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins GCE e2e failed for commit c4652055208f3751baa41dd69c0139a8ca49194d. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins GKE smoke e2e failed for commit c4652055208f3751baa41dd69c0139a8ca49194d. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins Kubemark GCE e2e failed for commit c4652055208f3751baa41dd69c0139a8ca49194d. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

I found a bug in the eviction manager tests. We were not assigning pods a UID, so the cached stats function was always returning the last (in order of when pods were added) pod's statsFunc. This meant that all calls to statsFunc returned the same value. This did not break tests because we always passed in the pod we wanted to fail as the first pod, and the eviction manager would leave that ordering intact when pods tie in their consumption. Changing the order of pods broke all tests in eviction_manager_test.go. Changing the newPod function in helpers_test.go to include a UID based on the name fixed the problem.

Jenkins verification failed for commit c4652055208f3751baa41dd69c0139a8ca49194d. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Jenkins GCE Node e2e failed for commit f90878158b4670dc6b393af63358843e7dcc437c. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@derekwaynecarr @dchen1107 this all ready to go as soon as one of you has the chance to review it.

pkg/kubelet/eviction/eviction_manager_test.go, line 103 at r1 (raw file):

      memoryWorkingSet string
  }{
      {name: "guaranteed-low", requests: newResourceList("100m", "1Gi"), limits: newResourceList("100m", "1Gi"), memoryWorkingSet: "200Mi"},

Changed ordering to prevent regression on bug described in git comments.

Comments from Reviewable

pkg/kubelet/eviction/eviction_manager_test.go, line 117 at r1 (raw file):

      podStats[pod] = podStat
  }
  podToEvict := pods[5]

Eviction manager reorders pods when choosing which pod to evict, so grab a reference to the correct pod to evict now...

Comments from Reviewable

pkg/kubelet/eviction/helpers_test.go, line 1570 at r1 (raw file):

      ObjectMeta: api.ObjectMeta{
          Name: name,
          UID:  types.UID(name),

This is to fix the bug described in the git comments.

Comments from Reviewable

/lgtm

pkg/kubelet/server/stats/summary.go, line 118 at r1 (raw file):

  }

  nodeFsInodesUsed := *sb.rootFsInfo.Inodes - *sb.rootFsInfo.InodesFree

Is this safe to do?

Comments from Reviewable

pkg/kubelet/server/stats/summary.go, line 118 at r1 (raw file):

Comments from Reviewable

@k8s-bot gci gke e2e test this

@k8s-bot gci gke e2e test this

Jenkins GCI GKE smoke e2e failed for commit 4ca7f9f. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-bot gci gke e2e test this

LGTM

@k8s-bot unit test this

Jenkins unit/integration failed for commit 4ca7f9f. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-bot unit test this

Automatic merge from submit-queue