Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: recognize us-east-2 region #35013

Merged
merged 1 commit into from
Nov 2, 2016
Merged

AWS: recognize us-east-2 region #35013

merged 1 commit into from
Nov 2, 2016

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Oct 18, 2016 •
edited by jessfraz
Loading

The newly announced region must be added to our list of known regions.

AWS: recognize us-east-2 region

This change is Reviewable

@justinsb
AWS: recognize us-east-2 region
80d4391 
The newly announced region must be added to our list of known regions.
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Oct 18, 2016
@justinsb justinsb mentioned this pull request Oct 18, 2016
Merged
@justinsb
Copy link
Member Author

This is needed to run in us-east-2, otherwise we get

Oct 18 03:39:04 ip-172-20-58-230 kubelet[2850]: error: failed to run Kubelet: could not init cloud provider "aws": not a valid AWS zone (unknown region): us-east-2a

We could maybe skip this check when we get the region from the AWS metadata itself, but that's a separate issue...

@justinsb justinsb added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherrypick-candidate and removed release-note-label-needed labels Oct 18, 2016
@justinsb justinsb mentioned this pull request Oct 18, 2016
Closed
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@justinsb justinsb added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 18, 2016
@justinsb justinsb mentioned this pull request Oct 18, 2016
Merged
@justinsb
Copy link
Member Author

@k8s-bot gci gke e2e test this

4 similar comments
@justinsb
Copy link
Member Author

@k8s-bot gci gke e2e test this

@chrislovecnm
Copy link
Contributor

@k8s-bot gci gke e2e test this

@justinsb
Copy link
Member Author

@k8s-bot gci gke e2e test this

@justinsb
Copy link
Member Author

@k8s-bot gci gke e2e test this

@chrislovecnm
Copy link
Contributor

Did it pass? OMG

errordeveloper
errordeveloper approved these changes Oct 23, 2016
View reviewed changes
Copy link
Member

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinsb
Copy link
Member Author

@erictune I marked this P1 because without it k8s won't run in the new us-east-2 region. Will follow up with a cherry-pick to 1.4

@paultyng
Copy link

Will there be a cherry pick to 1.3?

@chrislovecnm
Copy link
Contributor

@paultyng with the SSL bug, everyone needs to upgrade that, but yes we should have it

@chrislovecnm
Copy link
Contributor

TLS cert issue that is in 1.3

@justinsb
Copy link
Member Author

ping @erictune

@paultyng
Copy link

Any ability to escalate this? Its very minor, and actively holding up using 1.3 on the AWS region. 1.4 at least has the work around to ignore region validation.

@chrislovecnm
Copy link
Contributor

@justinsb can u tag this with a P0. @erictune paging @erictune

@paultyng this is assigned to a lead, and I asked to have this bumped to a P0

@erictune
Copy link
Member

erictune commented Nov 1, 2016

lgtm

@erictune erictune added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 80d4391. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7760c2f into kubernetes:master Nov 2, 2016
@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 3, 2016 •
edited
Loading

@erictune can we get this back ported into 1.4.x?

@krisnova krisnova mentioned this pull request Nov 9, 2016
Closed
@justinsb justinsb mentioned this pull request Nov 15, 2016
Closed
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@paultyng
Copy link

@justinsb I think that label needs to be reapplied with the milestone?

This is still an issue for me. There is the config to override region checking, but it doesn't seem to apply for dynamic volume provisioning, so any chart using dynamic volumes on 1.4 will not work in us-east-2.

That's what I've found so far at least.

@chrislovecnm
Copy link
Contributor

@paultyng which version of K8s?

@justinsb
Copy link
Member Author

@paultyng can you open an issue with what you're seeing? AFAIK this is the only place we list zones.

@justinsb justinsb added this to the v1.4 milestone Nov 19, 2016
@jessfraz jessfraz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 19, 2016
@jessfraz jessfraz mentioned this pull request Nov 19, 2016
Merged
@jessfraz
Copy link
Contributor

cherry-picked in #37140

@justinsb
Copy link
Member Author

Thanks @jessfraz - I guess I finally figured out the magic cherry-pick labels!

@paultyng
Copy link

@justinsb I'll try to repro tomorrow at work. This was in 1.4.6, and I believe its going through this code as well, but for some reason not respecting the config value when this code is hit via the dynamic volume provisioning. But I'll try to get some extra info for you. Thanks for the cherry pick.

jessfraz added a commit that referenced this pull request Dec 2, 2016
@jessfraz
Merge pull request #37140 from jessfraz/automated-cherry-pick-of-#33848-
9954e31 
#34778-#35013-#36924-origin-release-1.4

Automated cherry pick of #33848 #34778 #35013 #36924
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@hodovska hodovska mentioned this pull request Dec 14, 2016
Closed
hodovska pushed a commit to hodovska/origin that referenced this pull request Dec 14, 2016
@dhodovsk
Patch: AWS - extend list of known reqions
f21f749 
This is a patch created from kubernetes v1.4 and v1.5 commits:
80d4391 - AWS: recognize us-east-2 region: kubernetes/kubernetes#35013
e8b4875 - AWS: recognize eu-west-2 region: kubernetes/kubernetes#38746
e2342eb - AWS: Recognize ca-central-1 region: kubernetes/kubernetes#38410
This was referenced Dec 14, 2016
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

Assignees

@erictune erictune

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
10 participants
@justinsb @k8s-cherrypick-bot @chrislovecnm @paultyng @erictune @k8s-ci-robot @k8s-github-robot @jessfraz @errordeveloper @googlebot