Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate third party resources from master (moves + consequences) #34976

Merged
merged 1 commit into from
Oct 19, 2016
Merged

separate third party resources from master (moves + consequences) #34976

merged 1 commit into from
Oct 19, 2016
+332 −308

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Oct 17, 2016 •
edited by k8s-oncall
Loading

Remove the third party resource code from the main Master struct. I think we may be able to get this down to particular way to configure/New a generic API server.

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-label-needed labels Oct 17, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 508f052. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 508f052. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 508f052. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@deads2k
Copy link
Contributor Author

deads2k commented Oct 18, 2016

@k8s-bot test this: issue #34986

@fejta
Copy link
Contributor

fejta commented Oct 18, 2016

@k8s-bot verify test this

sttts
sttts reviewed Oct 18, 2016
View reviewed changes
pkg/master/thirdparty.go
@@ -0,0 +1,319 @@
/*
Copyright 2014 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016

sttts
sttts reviewed Oct 18, 2016
View reviewed changes
pkg/master/thirdparty.go
limitations under the License.
*/

package master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there dependencies left to the master? If not, move it into pkg/master/thirdparty to make that clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there dependencies left to the master? If not, move it into pkg/master/thirdparty to make that clear.

moved

@deads2k deads2k force-pushed the api-30-separate-third-party branch from 508f052 to 4883147 Compare October 18, 2016 12:36
@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 18, 2016
@sttts
Copy link
Contributor

sttts commented Oct 18, 2016

lgtm

@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2016
@deads2k deads2k force-pushed the api-30-separate-third-party branch from 4883147 to adf0920 Compare October 18, 2016 13:49
@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 18, 2016
@deads2k deads2k mentioned this pull request Oct 18, 2016
Merged
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit adf09201f09688f1c196f6b1f2be47a0b0b047f9. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@deads2k deads2k force-pushed the api-30-separate-third-party branch from adf0920 to f9cbc42 Compare October 19, 2016 11:45
@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 19, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit f9cbc42. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6b56d7b into kubernetes:master Oct 19, 2016
@deads2k deads2k deleted the api-30-separate-third-party branch February 1, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

Assignees

@sttts sttts

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deads2k @k8s-ci-robot @fejta @sttts @k8s-github-robot @googlebot