@erictune Is there a reason why the auth stuff should stay public?

@smarterclayton Is there a reason why the API_x stuff should stay public?

no objection to the change. wait for clayton though.

We no longer need API_ public (our equiv of standalone.go is https://github.com/openshift/origin/blob/master/pkg/cmd/server/kubernetes/master.go).

We may need the auth stuff to remain public - David is starting on the policy stuff and we may want to prototype it first.

On Jan 14, 2015, at 7:38 PM, Daniel Smith notifications@github.com wrote:

@erictune Is there a reason why the auth stuff should stay public?

@smarterclayton Is there a reason why the API_x stuff should stay public?

—
Reply to this email directly or view it on GitHub.

We need handler container public and installswagger public.

https://github.com/openshift/origin/blob/master/pkg/cmd/server/origin/master.go

master really needs to be a factory with a default path, and the ability to reuse more code. It's kind of a black hole in terms of its influence. If I had to state a concrete use case, I would phrase it as "let people building on top of Kubernetes be able to reproduce the bulk of master functionality". Ie, someone wants to provide their own plugins, or wrap the Kube api with a simple golang filter should be able to.

What's the best way to encode these things? Tests on master? The Kube service publish is a great example of reuse - I want to sync a running component into Kube, even though I'm not on Kube.

On Jan 14, 2015, at 7:43 PM, Daniel Smith notifications@github.com wrote:

Assigned #3494 to @smarterclayton.

—
Reply to this email directly or view it on GitHub.

Thanks for the pointers clayton.
I do not see InstallSwaggerAPI being used in openshift.

I have updated the PR as per your comments.
Please take another look.

LGTM

@nikhiljindal Please rebase.

Rebased. Its now ready to merge!