Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e invalid JSON, ensure CLI communicates invalid JSON errors effectively #3464

Merged
merged 4 commits into from
Jan 14, 2015
Merged

Fix e2e invalid JSON, ensure CLI communicates invalid JSON errors effectively #3464

merged 4 commits into from
Jan 14, 2015

Conversation

smarterclayton
Copy link
Contributor

It should be an error to pass zero arguments to create.

services.sh was passing JSON that golang JSON decoder does not accept (trailing commas on the last value) which the YAML decoder did accept.

@smarterclayton
Remove trailing commas from e2e services.sh
d986028
@smarterclayton
Add --v=4 to e2e bash executions by default
abc6217 
Will allow more debugging output to be available in CLI
@smarterclayton
Add more tests around JSON/YAML decoding from the CLI
31413c8 
Switch the ignore stream errors behavior to print a Warningf on
failure to parse, not v(2)
@smarterclayton
Ignore empty objects from streams and error when nothing passed to cr…
ccdc20d 
…eate

Passing zero objects to create should be an error
@smarterclayton
Copy link
Contributor Author

Fixes part of #3459

@smarterclayton
Copy link
Contributor Author

There may still be an e2e problem after this -

Verifying the portals from a container
service1 portal failed from container, expected:

            e6249857-9c17-11e4-bb3f-42010af0700d
    e625e5e1-9c17-11e4-bb3f-42010af0700d
    e626e4df-9c17-11e4-bb3f-42010af0700d

        got:

            e625e5e1-9c17-11e4-bb3f-42010af0700d
    e626e4df-9c17-11e4-bb3f-42010af0700d
    e626e4df-9c17-11e4-bb3f-42010af0700d

@zmerlynn
Copy link
Member

LGTM. services.sh is flaky at the best of times, unfortunately. :(

zmerlynn added a commit that referenced this pull request Jan 14, 2015
@zmerlynn
Merge pull request #3464 from smarterclayton/fix_invalid_json_in_serv…
e14d5f3 
…ices.sh

Fix e2e invalid JSON, ensure CLI communicates invalid JSON errors effectively
@zmerlynn zmerlynn merged commit e14d5f3 into kubernetes:master Jan 14, 2015
@smarterclayton smarterclayton deleted the fix_invalid_json_in_services.sh branch February 11, 2015 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarterclayton @zmerlynn