Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge string flag into util flag #34587

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Merge string flag into util flag #34587

merged 1 commit into from
Oct 14, 2016

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Oct 12, 2016 •
edited
Loading

Continuing my work on #15634

This refactoring is expected to be completely finished and then I will add a verify scripts in hack

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Oct 12, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit eb81ef6. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@j3ffml
Copy link
Contributor

j3ffml commented Oct 12, 2016

@k8s-bot gci gke e2e test this

@j3ffml j3ffml added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 12, 2016
@resouer
Copy link
Contributor Author

resouer commented Oct 13, 2016

Seems to be a flaky test?

@k8s-github-robot k8s-github-robot mentioned this pull request Oct 13, 2016
Closed
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9adbbf2 into kubernetes:master Oct 14, 2016
@resouer resouer deleted the stringflag branch August 3, 2017 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@j3ffml j3ffml

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@resouer @k8s-ci-robot @j3ffml @k8s-github-robot @googlebot