Test x509 intermediates correctly #34524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/L
liggitt
added
release-note
liggitt
commented
Oct 11, 2016
| return nil, false, nil | ||
| } | ||
|
|
||
| // Use intermediates, if provided |
There was a problem hiding this comment.
see https://golang.org/src/crypto/tls/handshake_server.go, processCertsFromClient for how the stdlib verifies the cert chain
only the leaf cert is verified, the remaining certs are client-supplied intermediates
|
lgtm. Tests aren't green though. Straight picks don't me to look at them again. |
deads2k
added
the
lgtm
liggitt
added
the
priority/important-soon
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
jessfraz
added
cherrypick-candidate
cherry-pick-approved
|
Removing label |
krousey
referenced
this pull request
Oct 20, 2016
…4-upstream-release-1.3 Automated cherry pick of #35212 Manual merge because submit queue is blocked due to unrelated breakages on a branch that this isn't even merging into, and because this is a critical fix.
roberthbailey
added a commit
that referenced
this pull request
Oct 21, 2016
…4-upstream-release-1.2 Automated cherry pick of #34524
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…k-of-#34524-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#34524 Cherry pick of kubernetes#34524 on release-1.4. kubernetes#34524: Test x509 intermediates correctly
shyamjvs
referenced
this pull request
in shyamjvs/kubernetes
Dec 1, 2016
…k-of-#34524-upstream-release-1.3 Automated cherry pick of kubernetes#35212 Manual merge because submit queue is blocked due to unrelated breakages on a branch that this isn't even merging into, and because this is a critical fix.
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…k-of-#34524-upstream-release-1.2 Automated cherry pick of kubernetes#34524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34517
This change is