Remove CONDITION from event object completely #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am good with this. @lavalamp ? |
| @@ -825,7 +826,7 @@ type Event struct { | |||
| // TODO: provide exact specification for format. | |||
| Source string `json:"source,omitempty" description:"component reporting this event; short machine understandable string"` | |||
| // Host name on which the event is generated. | |||
| Host string `json:"host,omitempty"` | |||
| Host string `json:"host,omitempty" description:"name on which the event is generated"` | |||
There was a problem hiding this comment.
location of component reporting this event?
|
LGTM-- just a few nits |
|
Nits addressed. Commits squashed. |
|
E2E looks good: |
# *** ERROR: *** Some files have not been gofmt'd. To fix these # errors, run gofmt -s -w <file>, or cut and paste the following: # gofmt -s -w pkg/kubecfg/resource_printer.go pkg/proxy/config/config.go pkg/runtime/types.go # # Your commit will be aborted unless you override this warning. To # commit in spite of these format errors, delete the following line: # COMMIT_BLOCKED_ON_GOFMT
|
LGTM, will merge when travis finishes. |
lavalamp
added a commit
that referenced
this pull request
Jan 14, 2015
Remove CONDITION from event object completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3172
Removes the
CONDITIONcolumn from "kubectl get events" output and from theEventobjectSee #3172 for rational