Fix broken hack/cluster-validate.sh because output-versions were not locked #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions Add more guards against bad behavior. A follow up commit will ensure that when the flags for api-version are specified, they default to the correct values that client.SetKubernetesDefaults would use.
|
LGTM |
lavalamp
added a commit
that referenced
this pull request
Jan 14, 2015
Fix broken hack/cluster-validate.sh because output-versions were not locked
|
Thanks for quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combination of changes to kubectl get and clientcmd resulted in no api-version
value being set, which resulted in converting to internal. Make that unpossible.
@lavalamp