Node status updater should SetNodeStatusUpdateNeeded if it fails to #34368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
|
Jenkins Kubemark GCE e2e failed for commit 69b1b75. Full PR test history. The magic incantation to run this job again is |
|
Jenkins GCI GCE e2e failed for commit 69b1b75. Full PR test history. The magic incantation to run this job again is |
saad-ali
suggested changes
Oct 19, 2016
|
|
||
| glog.V(3).Infof( | ||
| "Updating status for node %q succeeded. patchBytes: %q", | ||
| //updateNode, _ := nsu.kubeClient.Core().Nodes().Get(string(nodeName)) |
| @@ -105,7 +108,7 @@ func (nsu *nodeStatusUpdater) UpdateNodeStatuses() error { | |||
| err) | |||
| } | |||
|
|
|||
| _, err = nsu.kubeClient.Core().Nodes().PatchStatus(string(nodeName), patchBytes) | |||
| node, err = nsu.kubeClient.Core().Nodes().PatchStatus(string(nodeName), patchBytes) | |||
There was a problem hiding this comment.
Is node used anywhere? If not, replace with _.
update status When volume controller tries to update the node status, if it fails to update the nodes status, it should call SetNodeStatusUpdateNeeded so that the volume list could be updated next time.
jingxu97
force-pushed
the
Oct/statusupdate-10-7
branch
from
69b1b75 to
70efadc
Compare
|
@saad-ali PTAL |
|
LGTM |
saad-ali
added
release-note-none
|
Let's cherry pick this to v1.4 |
jessfraz
added
the
cherry-pick-approved
jingxu97
added
the
lgtm
|
@saad-ali Could you please take a look of this PR? It shows reviewer request changes? |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
saad-ali
approved these changes
Oct 26, 2016
|
Automatic merge from submit-queue |
|
cherrypicked in #35653 |
jessfraz
added
release-note
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 28, 2016
#35158-#35321-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of #34368 #35158 #35321 Cherry pick of #34368 #35158 #35321 on release-1.4. #34368: Node status updater should SetNodeStatusUpdateNeeded if it #35158: Fixing flake caused by lack of polling during read. #35321: Adding rkt binary to GCI nodes via cloud-init. This is
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#34368-kubernetes#35158-kubernetes#35321-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#34368 kubernetes#35158 kubernetes#35321 Cherry pick of kubernetes#34368 kubernetes#35158 kubernetes#35321 on release-1.4. kubernetes#34368: Node status updater should SetNodeStatusUpdateNeeded if it kubernetes#35158: Fixing flake caused by lack of polling during read. kubernetes#35321: Adding rkt binary to GCI nodes via cloud-init. This is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update status
When volume controller tries to update the node status, if it fails to
update the nodes status, it should call SetNodeStatusUpdateNeeded so
that the volume list could be updated next time.
This change is