Improve source ip preservation test, fail the test instead of panic. #34030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
ixdy
approved these changes
Oct 4, 2016
| if len(outputs) != 2 { | ||
| // fail the test if output format is unexpected | ||
| framework.Failf("exec pod returned unexpected stdout format: [%v]\n", stdout) | ||
| return execPodIp, "" |
There was a problem hiding this comment.
FYI the Failf will abort, so you don't really need this line.
There was a problem hiding this comment.
Right, thanks for telling!
ixdy
added
release-note-none
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
This was referenced Oct 21, 2016
jessfraz
added
cherrypick-candidate
cherry-pick-approved
jessfraz
added
release-note
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-of-#34030-kubernetes#34107-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#34030 kubernetes#34107 Cherry pick of kubernetes#34030 kubernetes#34107 on release-1.4. kubernetes#34030: examine output format before return, fail the test instead of kubernetes#34107: Fix kubernetes#31085, include output checking in retry loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #31085.
The source IP preserve test starts to be flake again. Sending out this PR to get rid of panicing and log the unexpected output for future investigation.
@freehan
This change is