Add local option to the label command #33990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was split out of #28949 |
k8s-github-robot
added
size/M
deads2k
added
release-note
|
@asalkeld Can you add a test to |
Oh, and while I'm thinking about it. |
asalkeld
force-pushed
the
local-option-label
branch
from
be4feee to
c2b8377
Compare
|
@deads2k I have added the test-cmd.sh test. I'll do the annotate one separately. |
|
Jenkins unit/integration failed for commit c2b8377fd271e543783cfda467c1ac2ddbf4b31f. Full PR test history. The magic incantation to run this job again is |
This is to be used with the new "set selector" command.
asalkeld
force-pushed
the
local-option-label
branch
from
c2b8377 to
5cb945d
Compare
deads2k
added
the
lgtm
|
lgtm |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add the --local option to be both consistent with other commands and so it can be used with "set selector" and "create service".
Which issue this PR fixes
Related: #7296
Special notes for your reviewer:
None
Release note:
This change is