Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for file size if the reading content returns empty #33976

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Add a check for file size if the reading content returns empty #33976

merged 1 commit into from
Oct 5, 2016

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Oct 3, 2016 •
edited by jessfraz
Loading

In order to debug the flaky tests for writing/reading files via
contains, this PR adds a check for file size if reading returns empty
content.

Add a check for file size if the reading content returns empty

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Oct 3, 2016
@jingxu97
Add a check for file size if the reading content returns empty
871a15a 
In order to debug the flaky tests for writing/reading files via
contains, this PR adds a check for file size if reading returns empty
content.
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 871a15a. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 871a15a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali saad-ali added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 3, 2016
@jingxu97
Copy link
Contributor Author

jingxu97 commented Oct 4, 2016

@k8s-bot unit test this

@saad-ali
Copy link
Member

saad-ali commented Oct 4, 2016

Is this PR still needed or can we close it?

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a9003a3 into kubernetes:master Oct 5, 2016
@saad-ali saad-ali mentioned this pull request Nov 7, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Nov 8, 2016
Merge pull request #36398 from saad-ali/automated-cherry-pick-of-#33976-
f9a5a40 
#35560-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #33976 #35560 upstream release 1.4

Cherry pick PRs #33976 and #35560 on behalf of @jingxu97 to 1.4 branch to fix `Pod disks...` flakes.
@jessfraz jessfraz added this to the v1.4 milestone Nov 9, 2016
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 9, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#36398 from saad-ali/automated-cherry-pi…
201ba25 
…ck-of-#33976-kubernetes#35560-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#33976 kubernetes#35560 upstream release 1.4

Cherry pick PRs kubernetes#33976 and kubernetes#35560 on behalf of @jingxu97 to 1.4 branch to fix `Pod disks...` flakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@jingxu97 @k8s-ci-robot @saad-ali @k8s-github-robot @jessfraz @googlebot