CRI: Remove the mount name and port name. #33970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-gu
added
area/kubelet-api
sig/node
|
LGTM |
|
LGTM |
|
Jenkins unit/integration failed for commit b5070c3. Full PR test history. The magic incantation to run this job again is |
k8s-github-robot
added
the
size/L
|
LGTM |
yifan-gu
added
the
lgtm
|
Jenkins verification failed for commit 7335321ee8ce09303af7d816a1adf922dc8c6552. Full PR test history. The magic incantation to run this job again is |
added 2 commits
October 4, 2016 13:10
Per discussion on kubernetes#33873. Currently the mount name is not being used and also involves some incorrect usage (sometimes it's referencing a mount name, sometimes it's referecing a volume name), so we decide to remove it from CRI. The port name is also not used, so remove it as well.
k8s-github-robot
removed
the
lgtm
|
Updated the |
yifan-gu
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #33873.
Currently the mount name is not being used and also involves some
incorrect usage (sometimes it's referencing a mount name, sometimes
it's referecing a volume name), so we decide to remove it from CRI.
The port name is also not used, so remove it as well.
Fix #33873
Fix #33526
/cc @kubernetes/sig-node @kubernetes/sig-rktnetes
This change is