fix kubectl taint e2e flake: add retries for removing taint #33872
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-wangzefeng
added
the
release-note-none
|
/cc @davidopp |
k8s-github-robot
added
the
size/S
|
Jenkins GKE smoke e2e failed for commit b8b92a1. Full PR test history. The magic incantation to run this job again is |
|
LGTM Thanks! |
davidopp
added
the
lgtm
|
@k8s-bot gke e2e test this |
|
Jenkins unit/integration failed for commit b8b92a1. Full PR test history. The magic incantation to run this job again is |
|
@k8s-bot unit test this |
|
Automatic merge from submit-queue |
jessfraz
added
cherry-pick-approved
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Why we need it: recent failures occurred in #29503 are caused by taints removing conflict on nodes, this PR is to fix it. (#33073 fixed taints updating conflict, but not taints removing.)
What this PR does: use
runKubectlRetryOrDie()instead ofRunKubectlOrDie()in all the places in "Kubectl taint" e2e tests.Which issue this PR fixes : fixes part of #29503, (would like to keep this issue open for some days more to make sure no other failures occur)
Special notes for your reviewer: NONE
Release note: NONE
This change is