Added kubelet config source from apiserver. #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
part of #2483 |
|
@thockin you were working with sources too. |
|
Thanks for the heads up @erictune. I'll sync up with you tomorrow. |
6 tasks
| "github.com/golang/glog" | ||
| ) | ||
|
|
||
| type podLW interface { |
There was a problem hiding this comment.
Is this interface needed? Can you just use cache.ListerWatcher?
|
This is ready for oncall to assign a reviewer. |
| send := func(objs []interface{}) { | ||
| var bpods []api.BoundPod | ||
| for _, o := range objs { | ||
| pod := o.(*api.Pod) |
There was a problem hiding this comment.
I think you need to use the bound pod factory from pkg/registry/pod...
There was a problem hiding this comment.
BoundPodFactory can't be easily reused. And I plan to delete it once this series of changes finishes.
I reviewed what MakeBoundPod does:
api.Scheme.Convert-- doing that already- set env vars -- I intend this to be done in a different part of kubelet in a different PR
- sets selflink -- Need to add this.
|
If calling the bound pod factory proves difficult, you may need to simultaneously with this change wire real pods through the kubelet... |
|
LGTM, but travis is broken |
|
PTAL |
|
LGTM |
lavalamp
added a commit
that referenced
this pull request
Jan 12, 2015
Added kubelet config source from apiserver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.