Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct env var name in configure-helper #33848

Merged
merged 2 commits into from
Sep 30, 2016
Merged

Correct env var name in configure-helper #33848

merged 2 commits into from
Sep 30, 2016

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Sep 30, 2016 •
edited by jessfraz
Loading

The variable should be KUBEPROXY_TEST_ARGS, not KUBE_PROXY_TEST_ARGS.

Correct env var name in configure-helper

This change is Reviewable

@mtaufen
Correct env var name in configure-helper
73b64e6 
The variable should be KUBEPROXY_TEST_ARGS, not KUBE_PROXY_TEST_ARGS.
@mtaufen mtaufen added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Sep 30, 2016
@mtaufen mtaufen mentioned this pull request Sep 30, 2016
Closed
@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2016
@wojtek-t
Copy link
Member

lgtm

vishh
vishh reviewed Sep 30, 2016
View reviewed changes
cluster/gce/gci/configure-helper.sh
@@ -1131,7 +1131,7 @@ function start-rescheduler {
function setup-kubelet-dir {
echo "Making /var/lib/kubelet executable for kubelet"
mount --bind /var/lib/kubelet /var/lib/kubelet/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are there, can you change --bind to -B to be consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

vishh
vishh approved these changes Sep 30, 2016
View reviewed changes
Copy link
Contributor

@vishh vishh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM. Feel free to self -lgtm this patch once tests are green.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 30, 2016
@adityakali
Copy link
Contributor

Thanks for the quick fix! Please also cherry-pick this for 1.4.1.

@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Sep 30, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit edcf97d. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 30, 2016

@k8s-bot unit test this issue #33838

@mtaufen
Copy link
Contributor Author

mtaufen commented Sep 30, 2016

@k8s-bot gci gke test this issue #IGNORE

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit edcf97d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@gmarek
Copy link
Contributor

gmarek commented Sep 30, 2016

@mtaufen - thanks for fixing this!

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit edcf97d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 20e764a into kubernetes:master Sep 30, 2016
@wojtek-t wojtek-t mentioned this pull request Oct 1, 2016
Closed
@mtaufen
Copy link
Contributor Author

mtaufen commented Nov 17, 2016

@jessfraz @adityakali This still needs to be cherry-picked to 1.4.

@jessfraz jessfraz added this to the v1.4 milestone Nov 19, 2016
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Nov 19, 2016
@jessfraz jessfraz mentioned this pull request Nov 19, 2016
Merged
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 19, 2016
@jessfraz
Copy link
Contributor

cherry-pick opened in #37140

jessfraz added a commit that referenced this pull request Dec 2, 2016
@jessfraz
Merge pull request #37140 from jessfraz/automated-cherry-pick-of-#33848-
9954e31 
#34778-#35013-#36924-origin-release-1.4

Automated cherry pick of #33848 #34778 #35013 #36924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishh vishh vishh approved these changes

Assignees

@vishh vishh

@wojtek-t wojtek-t

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
9 participants
@mtaufen @wojtek-t @adityakali @k8s-ci-robot @k8s-github-robot @gmarek @jessfraz @vishh @googlebot