Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the purpose of dramatically-simplify-cluster-creation.md #33746

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Clarify the purpose of dramatically-simplify-cluster-creation.md #33746

merged 2 commits into from
Oct 13, 2016

Conversation

errordeveloper
Copy link
Member

@errordeveloper errordeveloper commented Sep 29, 2016 •
edited by k8s-oncall
Loading

What this PR does / why we need it:
We have merged docs/proposals/dramatically-simplify-cluster-creation.md mostly because we'd like to keep accurate historic records. This change adds a note to clarify this.

Release note:

NONE

This change is Reviewable

@k8s-github-robot k8s-github-robot added kind/design Categorizes issue or PR as related to design. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 29, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 4c9fa32. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@bgrant0607 bgrant0607 assigned mikedanese and unassigned bgrant0607 Sep 29, 2016
mikedanese
mikedanese reviewed Sep 29, 2016
View reviewed changes
docs/proposals/dramatically-simplify-cluster-creation.md
@@ -29,6 +29,10 @@ Documentation for other releases can be found at

# Proposal: Dramatically Simplify Kubernetes Cluster Creation


> ***Please note: this proposal doesn't reflect final implementation, it's here for the purpose of capturing the original ideas.***
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the implication for all proposals.

@mikedanese mikedanese added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Sep 29, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2016
@errordeveloper
Copy link
Member Author

@k8s-bot gke e2e test this

On Fri, 30 Sep 2016 at 01:15 k8s-ci-robot notifications@github.com wrote:

Jenkins GKE smoke e2e failed
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/33746/kubernetes-pull-build-test-e2e-gke/14818/
for commit a7e8617
a7e8617.
Full PR test history http://pr-test.k8s.io/33746.

The magic incantation to run this job again is @k8s-bot gke e2e test this.
Please help us cut down flakes by linking to an open flake issue
https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open
when you hit one in your PR.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33746 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPWS8ofyHb10xcs7isf6jdQQlMmqehIks5qvFS1gaJpZM4KJ6fM
.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit a7e8617. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@mikedanese
Copy link
Member

@k8s-bot ok to test

@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit fdcfb80 into kubernetes:master Oct 13, 2016
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
Merge pull request kubernetes#33746 from errordeveloper/patch-1
a6c1429 
Automatic merge from submit-queue

Clarify the purpose of dramatically-simplify-cluster-creation.md

**What this PR does / why we need it**:
We have merged `docs/proposals/dramatically-simplify-cluster-creation.md` mostly because we'd like to keep accurate historic records. This change adds a note to clarify this.

**Release note**:
```release-note
NONE
```
@errordeveloper errordeveloper deleted the patch-1 branch January 9, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese mikedanese left review comments

Assignees

@mikedanese mikedanese

Labels
kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@errordeveloper @k8s-ci-robot @mikedanese @k8s-github-robot @googlebot @bgrant0607