Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in HPA: consider only running pods; proper denominator in avg. #33735

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Fixes in HPA: consider only running pods; proper denominator in avg. #33735

merged 1 commit into from
Sep 29, 2016

Conversation

jszczepkowski
Copy link
Contributor

@jszczepkowski jszczepkowski commented Sep 29, 2016 •
edited by jessfraz
Loading 

Fixes in HPA: consider only running pods; proper denominator in avg request calculations.

This change is Reviewable

@jszczepkowski
Fixes in HPA: consider only running pods; proper denominator in avg c…
0f0a9b6 
…alculations.

Fixes in HPA: consider only running pods; proper denominator in avg calculations.
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Sep 29, 2016
@jszczepkowski jszczepkowski mentioned this pull request Sep 29, 2016
Closed
@jszczepkowski jszczepkowski added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2016
@jszczepkowski jszczepkowski mentioned this pull request Sep 29, 2016
Closed
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@jszczepkowski jszczepkowski added this to the v1.4 milestone Sep 29, 2016
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 29, 2016
@mwielgus
Copy link
Contributor

mwielgus commented Sep 29, 2016 •
edited
Loading

Please include the issues that we hope to fix with this. Also give a credit to the spotter of the len() issue.

@mwielgus
Copy link
Contributor

After that - LGTM.

@jszczepkowski
Copy link
Contributor Author

The PR is base on #33529 by @hongshibao, it partially fixes #28692 and #30471.

@jszczepkowski jszczepkowski added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@hongshibao
Copy link
Contributor

👍

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 24031f5 into kubernetes:master Sep 29, 2016
@jessfraz jessfraz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 6, 2016
@jessfraz
Copy link
Contributor

jessfraz commented Oct 6, 2016

@jszczepkowski can you open the PR to cherry-pick this into release-1.4 for 1.4.1

@jszczepkowski jszczepkowski mentioned this pull request Oct 6, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 7, 2016
Merge pull request #34224 from jszczepkowski/automated-cherry-pick-of…
bc33a5b 
…-#33735-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #33735: Fixes in HPA ...

Fixes in HPA: consider only running pods; proper denominator in avg request calculations. It partially fixes #28692 and #30471

**Release note**:
```release-note
Fixes in HPA: consider only running pods; proper denominator in avg request calculations. 
```
@jessfraz
Copy link
Contributor

jessfraz commented Oct 7, 2016

was cherry-picked in #34224

@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 7, 2016
This was referenced Nov 2, 2016
Closed
Closed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#34224 from jszczepkowski/automated-cher…
1e18c58 
…ry-pick-of-#33735-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#33735: Fixes in HPA ...

Fixes in HPA: consider only running pods; proper denominator in avg request calculations. It partially fixes kubernetes#28692 and kubernetes#30471

**Release note**:
```release-note
Fixes in HPA: consider only running pods; proper denominator in avg request calculations. 
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mwielgus mwielgus

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@jszczepkowski @k8s-cherrypick-bot @mwielgus @k8s-github-robot @hongshibao @jessfraz @googlebot