Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/doc: add manifest schema #337

Merged
merged 2 commits into from
Jul 2, 2014
Merged

api/doc: add manifest schema #337

merged 2 commits into from
Jul 2, 2014

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Jul 2, 2014

ported the manifest from https://github.com/GoogleCloudPlatform/container-agent

a few notes:

>>> import json
>>> pod = json.loads(open('pod.json').read())
>>> manifest = pod['desiredState']['manifest']
>>> import jsonschema
>>> schema = json.loads(open('../doc/manifest-schema.json').read())
>>> jsonschema.validate(manifest, schema)
>>>
  • I didn't link it yet in the documentation (I have yet to figure out how to reference a subresource schema from an external file)

/cc @bgrant0607

@lavalamp
Copy link
Member

lavalamp commented Jul 2, 2014

Assigning to @bgrant0607 because he knows all about the /api directory. :)

bgrant0607
bgrant0607 reviewed Jul 2, 2014
View reviewed changes
api/doc/manifest-schema.json
"pattern": "^[a-z]([-a-z0-9]*[a-z0-9])*"
}
},
"required": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If required is legal to put before the list of properties, please do that, as you did above for image. If it's not (all examples I've seen using draft-04 place it afterward), please fix the image case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL

@bgrant0607
Copy link
Member

LGTM.

lavalamp added a commit that referenced this pull request Jul 2, 2014
@lavalamp
Merge pull request #337 from proppy/manifest-schema
0ee696c 
api/doc: add manifest schema
@lavalamp lavalamp merged commit 0ee696c into kubernetes:master Jul 2, 2014
keontang pushed a commit to keontang/kubernetes that referenced this pull request May 14, 2016
@pendoragon @ddysher
Merge pull request kubernetes#337 from Pendoragon/bug_fix
f9a96f8 
Tweak nginx setup on master for kubectl exec & port-forward.
keontang pushed a commit to keontang/kubernetes that referenced this pull request Jul 1, 2016
@pendoragon @ddysher
Merge pull request kubernetes#337 from Pendoragon/bug_fix
3052bd2 
Tweak nginx setup on master for kubectl exec & port-forward.
harryge00 pushed a commit to harryge00/kubernetes that referenced this pull request Aug 11, 2016
@pendoragon
Merge pull request kubernetes#337 from Pendoragon/bug_fix
0ba24c7 
Tweak nginx setup on master for kubectl exec & port-forward.
mqliang pushed a commit to mqliang/kubernetes that referenced this pull request Dec 8, 2016
@pendoragon @liubog2008
Merge pull request kubernetes#337 from Pendoragon/bug_fix
578298e 
Tweak nginx setup on master for kubectl exec & port-forward.
mqliang pushed a commit to mqliang/kubernetes that referenced this pull request Mar 3, 2017
@pendoragon @keontang
Merge pull request kubernetes#337 from Pendoragon/bug_fix
cae8fd9 
Tweak nginx setup on master for kubectl exec & port-forward.
seans3 pushed a commit to seans3/kubernetes that referenced this pull request Apr 10, 2019
@calebamiles
Merge pull request kubernetes#337 from kubernetes/dchen1107-patch-5
383d835 
Fix networking section's format and recategory
marun pushed a commit to marun/kubernetes that referenced this pull request Sep 14, 2020
@openshift-merge-robot
Merge pull request kubernetes#337 from marun/k8s-e2e-serial
e6c224a 
Bug 1873043: Enable k8s-e2e-gcp-serial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@proppy @lavalamp @bgrant0607