Reenable coverage and race detection on Travis #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
added
the
priority/critical-urgent
|
LGTM, thanks for fixing! |
Also add opinionated comment about using singletons in code
smarterclayton
force-pushed
the
test_coverage
branch
from
1f8a84f to
b38c25e
Compare
|
ag, found bug. testing again... |
lavalamp
added a commit
that referenced
this pull request
Jan 10, 2015
Reenable coverage and race detection on Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7d5ac85 accidentally disabled coverage and race (understandably, because they're soooo slow), and @lavalamp and I discussed leaving it disabled in hack/test-go.sh usage. This reenables it for travis. The difference now between race and non race is ~33% of total time, and coverage is non-trivial.
Fixed 3 other slow tests to take ~10s off test time.