Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout for federated ingress test. #33610

Merged
merged 1 commit into from Sep 30, 2016
Merged

Increase timeout for federated ingress test. #33610

merged 1 commit into from Sep 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2016 •
edited by jessfraz
Loading

Right now federated ingress e2e takes more than 1 minute, as we need to wait for the first clusters ingress to have an IP address allocated to it before creating the others. Sometimes this takes a while due to GCE loadbalancer backend delays.

Increase timeout for federated ingress test.

This change is Reviewable

@ghost ghost added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cherrypick-candidate labels Sep 27, 2016
@ghost ghost added this to the next-candidate milestone Sep 27, 2016
@ghost ghost assigned nikhiljindal Sep 27, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 27, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 8800b6f. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 8800b6f. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ghost ghost added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Sep 29, 2016
@ghost
Copy link
Author

ghost commented Sep 29, 2016

Applying LGTM as per #33502

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2016
@ghost ghost mentioned this pull request Sep 29, 2016
Closed
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5b83252 into kubernetes:master Sep 30, 2016
@ghost ghost mentioned this pull request Oct 4, 2016
Closed
@ghost ghost added the cherrypick-candidate label Oct 5, 2016
@ghost ghost modified the milestones: v1.4, next-candidate Oct 5, 2016
@jessfraz
Copy link
Contributor

jessfraz commented Oct 6, 2016

oh this seems super reasonable to cherry-pick to me, @quinton-hoole do you want to make the PR to release-1.4

@jessfraz jessfraz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 6, 2016
@ghost
Copy link
Author

ghost commented Oct 6, 2016

@jessfraz I thought our release scripts did that automatically?

@jessfraz
Copy link
Contributor

jessfraz commented Oct 6, 2016

@quinton-hoole I was under the impression it needed to be cherry-picked but now I'm making sure

@jessfraz jessfraz mentioned this pull request Oct 7, 2016
Merged
@jessfraz
Copy link
Contributor

jessfraz commented Oct 7, 2016

cherry-picked in #34299

@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 7, 2016
k8s-github-robot pushed a commit that referenced this pull request Oct 7, 2016
Merge pull request #34299 from jessfraz/automated-cherry-pick-of-#33794-
784aefd 
#33610-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of #33794 #33610 origin release 1.4

Cherry pick of #33794 #33610 on release-1.4.

#33794: Enable kubectl describe rs to work when apiserver does not
#33610: Increase tineout for federated ingress test.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#34299 from jessfraz/automated-cherry-pi…
0487e29 
…ck-of-#33794-kubernetes#33610-origin-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#33794 kubernetes#33610 origin release 1.4

Cherry pick of kubernetes#33794 kubernetes#33610 on release-1.4.

kubernetes#33794: Enable kubectl describe rs to work when apiserver does not
kubernetes#33610: Increase tineout for federated ingress test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-cherrypick-bot @k8s-ci-robot @k8s-github-robot @jessfraz @googlebot @nikhiljindal