Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe identifiers in Kubernetes #334

Merged
merged 1 commit into from
Jul 2, 2014

Conversation

smarterclayton
Copy link
Contributor

Resolves #199

@brendandburns
Copy link
Contributor

LGTM, I'll leave for @thockin and others to take a look at before we merge.


1) Each container name within a container manifest must be unique within that manifest

2) Each pod instance on the apiserver must have a unique identifier across space and time (UUID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the pod.ID field, correct? And it should equal the ContainerManifest's ID, field, should we choose to keep that as a thing, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, based on tentative agreement in #294. I can clarify that in the doc.

@lavalamp
Copy link
Member

lavalamp commented Jul 1, 2014

LGTM

brendandburns added a commit that referenced this pull request Jul 2, 2014
@brendandburns brendandburns merged commit 53bdb23 into kubernetes:master Jul 2, 2014
@smarterclayton smarterclayton deleted the add_identifier_doc branch February 11, 2015 02:21
vishh pushed a commit to vishh/kubernetes that referenced this pull request Apr 6, 2016
seans3 pushed a commit to seans3/kubernetes that referenced this pull request Apr 10, 2019
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
Update inflate/diff and corresponding tests
marun pushed a commit to marun/kubernetes that referenced this pull request Sep 14, 2020
Bug 1875194: UPSTREAM: 94609: Use namespace flag passed to RunKubectl* methods
linxiulei pushed a commit to linxiulei/kubernetes that referenced this pull request Jan 18, 2024
Metric format fixes on host/uptime and disk/*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container identifiers should be globally unique
3 participants