Update to etcd 3.0.10 #33393

timothysc · 2016-09-23T21:24:56Z

Problem Statement:
Update repository to use etcd 3.0.10 client libraries, fixes watch issue(s).

/cc @luxas @hongchaodeng @lavalamp @smarterclayton @wojtek-t @ingvagabund

etcd3: update to etcd 3.0.10

xref: #32404

This change is

k8s-ci-robot · 2016-09-23T21:48:12Z

Jenkins Kubemark GCE e2e failed for commit 99bfc1d. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-ci-robot · 2016-09-23T21:48:12Z

Jenkins GCE e2e failed for commit 99bfc1d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-ci-robot · 2016-09-23T22:03:23Z

Jenkins GKE smoke e2e failed for commit 99bfc1d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

wojtek-t · 2016-09-26T06:35:18Z

build/build-image/cross/Dockerfile

@@ -72,7 +72,7 @@ RUN mkdir $TMPDIR \
            github.com/jteeuwen/go-bindata/go-bindata

 # Download and symlink etcd. We need this for our integration tests.
-RUN export ETCD_VERSION=v2.2.1; \
+RUN export ETCD_VERSION=v3.0.10; \


I think we don't want to change build images and default configs yet.

Can you please just bump godeps in this PR?

@lavalamp - thoughts?

Well we want to do it early in the cycle, I just need to know when...?

You mean for testing purposes? If so, updating this is not necessary, see e.g.:
https://github.com/kubernetes/test-infra/blob/master/jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e-gce.yaml#L304

where we already have etcd3 enabled (some older version, but still).

@wojtek-t there have been some pretty nasty bug fixes since 3.0.4 which is why I'm tracking the fix: https://github.com/coreos/etcd/releases/

Up to you though, I can back-out that commit and just focus on the client fixes.

Sure - we can build a newer image for that (and we should do that).

All I'm saying is that we can test non-default images without actually changing tags in the codebase.

@wojtek-t ok, updated pr to only godep update.

k8s-ci-robot · 2016-09-26T15:21:59Z

Jenkins GCI Kubemark GCE e2e failed for commit a8dbab6. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark gci e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

luxas · 2016-09-26T16:49:12Z

@wojtek-t I assume we will use 3.1.x finally in the v1.5 release, right?

timothysc · 2016-09-26T17:16:44Z

@luxas most likely yes.

luxas · 2016-09-26T17:18:29Z

Great! Thanks

timothysc · 2016-09-26T20:37:57Z

@wojtek-t PTAL.

wojtek-t · 2016-09-27T05:23:49Z

lgtm

k8s-github-robot · 2016-09-27T05:30:28Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2016-09-27T06:12:43Z

Automatic merge from submit-queue

Since kubernetes#33393 is merged, the bug should have been fixed.

Automatic merge from submit-queue Revert "Work around the etcd watch issue" Reverts #33101 Since #33393 is merged, the bug should have been fixed.

Automatic merge from submit-queue revert #32012 (Unshare cluster in each test suite) revert #32012 Since #33393 is merged, the bug should have been fixed.

Since kubernetes#33393 is merged, the bug should have been fixed.

@hongchaodeng

#31704-#32831-#32907-#33003-#33349-#31190-#33581-#34089-#34234-#32822-#33393-#34246-#34435-#32477-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of #31189 #31704 #32831 #32907 #33003 #33349 #31190 #33581 #34089 #34234 #32822 #33393 #34246 #34435 #32477 upstream release 1.4 We are going to release etcd v3 in 1.4.x release. ``` Cherrypick etcd v3-related bug fixes to 1.4 branch ``` Those PRs include: - Updates of etcd Godeps - Update to pkg/storage/etcd directory - Two PR that were unnecessary to avoid conflicts: #31189 #31704 Automated cherry pick of #31189 #31704 #32831 #32907 #33003 #33349 #31190 #33581 #34089 #34234 #32822 #33393 #34246 #34435 #32477 @hongchaodeng @xiang90 @lavalamp @smarterclayton

k8s-cherrypick-bot · 2016-10-21T05:14:08Z

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Since kubernetes#33393 is merged, the bug should have been fixed.

@hongchaodeng

…ck-of-#31189-kubernetes#31704-kubernetes#32831-kubernetes#32907-kubernetes#33003-kubernetes#33349-kubernetes#31190-kubernetes#33581-kubernetes#34089-kubernetes#34234-kubernetes#32822-kubernetes#33393-kubernetes#34246-kubernetes#34435-kubernetes#32477-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#31189 kubernetes#31704 kubernetes#32831 kubernetes#32907 kubernetes#33003 kubernetes#33349 kubernetes#31190 kubernetes#33581 kubernetes#34089 kubernetes#34234 kubernetes#32822 kubernetes#33393 kubernetes#34246 kubernetes#34435 kubernetes#32477 upstream release 1.4 We are going to release etcd v3 in 1.4.x release. ``` Cherrypick etcd v3-related bug fixes to 1.4 branch ``` Those PRs include: - Updates of etcd Godeps - Update to pkg/storage/etcd directory - Two PR that were unnecessary to avoid conflicts: kubernetes#31189 kubernetes#31704 Automated cherry pick of kubernetes#31189 kubernetes#31704 kubernetes#32831 kubernetes#32907 kubernetes#33003 kubernetes#33349 kubernetes#31190 kubernetes#33581 kubernetes#34089 kubernetes#34234 kubernetes#32822 kubernetes#33393 kubernetes#34246 kubernetes#34435 kubernetes#32477 @hongchaodeng @xiang90 @lavalamp @smarterclayton

timothysc added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. area/etcd do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Sep 23, 2016

timothysc added this to the v1.5 milestone Sep 23, 2016

timothysc assigned lavalamp and wojtek-t Sep 23, 2016

googlebot added the cla: yes label Sep 23, 2016

timothysc mentioned this pull request Sep 23, 2016

Etcd is becoming our performance bottleneck for scalability #32361

Closed

k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Sep 23, 2016

wojtek-t reviewed Sep 26, 2016

View reviewed changes

Update etcd godep to 3.0.10 to fix known watch issue.

a8dbab6

timothysc force-pushed the etcd_3_0_10 branch from 99bfc1d to a8dbab6 Compare September 26, 2016 15:06

timothysc added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Sep 26, 2016

k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2016

wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2016

k8s-github-robot merged commit 417fc0b into kubernetes:master Sep 27, 2016

hongchaodeng mentioned this pull request Sep 27, 2016

Revert "Work around the etcd watch issue" #33536

Merged

hongchaodeng added a commit to hongchaodeng/kubernetes that referenced this pull request Sep 27, 2016

revert kubernetes#32012 (Unshare cluster in each test suite)

35917e5

Since kubernetes#33393 is merged, the bug should have been fixed.

hongchaodeng mentioned this pull request Sep 27, 2016

revert #32012 (Unshare cluster in each test suite) #33581

Merged

k8s-github-robot pushed a commit that referenced this pull request Sep 29, 2016

Merge pull request #33581 from hongchaodeng/r1

47e611b

Automatic merge from submit-queue revert #32012 (Unshare cluster in each test suite) revert #32012 Since #33393 is merged, the bug should have been fixed.

wojtek-t mentioned this pull request Oct 10, 2016

etcd3: use PrevKV to remove additional get #34246

Merged

wojtek-t modified the milestones: v1.4, v1.5 Oct 19, 2016

wojtek-t added the cherrypick-candidate label Oct 19, 2016

wojtek-t pushed a commit to wojtek-t/kubernetes that referenced this pull request Oct 19, 2016

revert kubernetes#32012 (Unshare cluster in each test suite)

7fcaf84

Since kubernetes#33393 is merged, the bug should have been fixed.

wojtek-t pushed a commit to wojtek-t/kubernetes that referenced this pull request Oct 20, 2016

revert kubernetes#32012 (Unshare cluster in each test suite)

402f385

Since kubernetes#33393 is merged, the bug should have been fixed.

wojtek-t mentioned this pull request Oct 20, 2016

Automated cherry pick of #31189 #31704 #32831 #32907 #33003 #33349 #31190 #33581 #34089 #34234 #32822 #33393 #34246 #34435 #32477 upstream release 1.4 #35205

Merged

k8s-cherrypick-bot removed the cherrypick-candidate label Oct 21, 2016

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

revert kubernetes#32012 (Unshare cluster in each test suite)

fbaec48

Since kubernetes#33393 is merged, the bug should have been fixed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to etcd 3.0.10 #33393

Update to etcd 3.0.10 #33393

timothysc commented Sep 23, 2016 •

edited by jessfraz

Loading

k8s-ci-robot commented Sep 23, 2016

k8s-ci-robot commented Sep 23, 2016

k8s-ci-robot commented Sep 23, 2016

wojtek-t Sep 26, 2016

timothysc Sep 26, 2016

wojtek-t Sep 26, 2016

timothysc Sep 26, 2016 •

edited

Loading

wojtek-t Sep 26, 2016

timothysc Sep 26, 2016

k8s-ci-robot commented Sep 26, 2016

luxas commented Sep 26, 2016

timothysc commented Sep 26, 2016

luxas commented Sep 26, 2016

timothysc commented Sep 26, 2016

wojtek-t commented Sep 27, 2016

k8s-github-robot commented Sep 27, 2016

k8s-github-robot commented Sep 27, 2016

k8s-cherrypick-bot commented Oct 21, 2016

Update to etcd 3.0.10 #33393

Update to etcd 3.0.10 #33393

Conversation

timothysc commented Sep 23, 2016 • edited by jessfraz Loading

k8s-ci-robot commented Sep 23, 2016

k8s-ci-robot commented Sep 23, 2016

k8s-ci-robot commented Sep 23, 2016

wojtek-t Sep 26, 2016

Choose a reason for hiding this comment

timothysc Sep 26, 2016

Choose a reason for hiding this comment

wojtek-t Sep 26, 2016

Choose a reason for hiding this comment

timothysc Sep 26, 2016 • edited Loading

Choose a reason for hiding this comment

wojtek-t Sep 26, 2016

Choose a reason for hiding this comment

timothysc Sep 26, 2016

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 26, 2016

luxas commented Sep 26, 2016

timothysc commented Sep 26, 2016

luxas commented Sep 26, 2016

timothysc commented Sep 26, 2016

wojtek-t commented Sep 27, 2016

k8s-github-robot commented Sep 27, 2016

k8s-github-robot commented Sep 27, 2016

k8s-cherrypick-bot commented Oct 21, 2016

timothysc commented Sep 23, 2016 •

edited by jessfraz

Loading

timothysc Sep 26, 2016 •

edited

Loading