Fix possible panic in PodAffinityChecker #33086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/XS
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
LGTM |
|
Oh and thanks for fixing! |
davidopp
added
lgtm
|
Automatic merge from submit-queue |
|
@davidopp you're welcome. I've created cherrypick PR |
jessfraz
added
release-note
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
This was referenced Oct 20, 2016
jessfraz
added
cherrypick-candidate
cherry-pick-approved
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…k-of-#33086-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#33086 Cherry pick of kubernetes#33086 on release-1.4.
Closed
timothysc
added
the
sig/scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
PodAffinityChecker.getMatchingAntiAffinityTerms()affinity.PodAntiAffinitycan benilin this place. This problem occurs e.g. whennilis passed asmetatoPodAffinityChecker.InterPodAffinityMatches().Stumbled upon it while working on #31136 (someone PTAL at that PR too, I've submitted it a month ago and seemingly no one noticed it), kube-controller-manager was crashing there.
This change is