Limit the number of names per image reported in the node status #32914
+23
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujuhong
added
priority/important-soon
|
/cc @dchen1107 |
k8s-github-robot
added
the
size/M
|
LGTM |
dchen1107
added
the
lgtm
lavalamp
reviewed
Sep 16, 2016
| @@ -501,8 +510,13 @@ func (kl *Kubelet) setNodeStatusImages(node *api.Node) { | |||
| } | |||
|
|
|||
| for _, image := range containerImages { | |||
| names := append(image.RepoDigests, image.RepoTags...) | |||
There was a problem hiding this comment.
Why Digests and Tags? Are they both really legit names?
There was a problem hiding this comment.
There is no actual "name" defined in docker images.. Digest is a content-addressable identifier which users can use to pull an image (which we also support in k8s), so it should be a legit "name" in our definition. I don't think there should be multiple digests per image (since it's sha256 hash based on the content), so I changed the order of the digests and tags to ensure that we always include the digest.
|
thanks for the quick fix! |
|
@k8s-bot test this issue: #IGNORE |
1 similar comment
|
GCE e2e build/test passed for commit 7ada991. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 7ada991. |
|
Automatic merge from submit-queue |
|
@pwittrock this doesn't need to go into 1.4.0 but it would be good for it to end up in a 1.4.x. |
|
thx |
|
@yujuhong can you open the pull request to cherry-pick this into release-1.4, thanks! |
jessfraz
added
the
cherry-pick-approved
yujuhong
added
release-note
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 6, 2016
#33163-#33227-#33359-#33605-#33967-#33977-#34158-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of #32914 #33163 #33227 #33359 #33605 #33967 #33977 #34158 origin release 1.4 Cherry pick of #32914 #33163 #33227 #33359 #33605 #33967 #33977 #34158 on release-1.4. #32914: Limit the number of names per image reported in the node #33163: fix the appending bug #33227: remove cpu limits for dns pod. The current limits are not #33359: Fix goroutine leak in federation service controller #33605: Add periodic ingress reconciliations. #33967: scheduler: cache.delete deletes the pod from node specified #33977: Heal the namespaceless ingresses in federation e2e. #34158: Add missing argument to log message in federated ingress
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#32914-kubernetes#33163-kubernetes#33227-kubernetes#33359-kubernetes#33605-kubernetes#33967-kubernetes#33977-kubernetes#34158-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#32914 kubernetes#33163 kubernetes#33227 kubernetes#33359 kubernetes#33605 kubernetes#33967 kubernetes#33977 kubernetes#34158 origin release 1.4 Cherry pick of kubernetes#32914 kubernetes#33163 kubernetes#33227 kubernetes#33359 kubernetes#33605 kubernetes#33967 kubernetes#33977 kubernetes#34158 on release-1.4. kubernetes#32914: Limit the number of names per image reported in the node kubernetes#33163: fix the appending bug kubernetes#33227: remove cpu limits for dns pod. The current limits are not kubernetes#33359: Fix goroutine leak in federation service controller kubernetes#33605: Add periodic ingress reconciliations. kubernetes#33967: scheduler: cache.delete deletes the pod from node specified kubernetes#33977: Heal the namespaceless ingresses in federation e2e. kubernetes#34158: Add missing argument to log message in federated ingress
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#32914-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#32914 Cherry pick of kubernetes#32914 on release-1.4. kubernetes#32914: Limit the number of names per image reported in the node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the number of names per image reported in the node status.
This fixes #32908
This change is