Fix 1.3 paused deployment test failure against >1.4 cluster #32901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proportionally scale deployments was introduced in v1.4 (kubernetes#20273), which caused this 1.3 test to fail on 1.4 clusters. This is cherrypicked into 1.3 merely for fixing test failues on kubernetes-e2e-gke-1.3-1.4-upgrade-cluster
janetkuo
added
priority/critical-urgent
k8s-github-robot
added
do-not-merge
|
GCE e2e build/test passed for commit d5230b4. |
jessfraz
added
lgtm
k8s-github-robot
added
the
do-not-merge
pwittrock
added
cherry-pick-approved
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit d5230b4. |
|
Automatic merge from submit-queue |
|
Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-deployment Automatic merge from submit-queue Fix 1.3 paused deployment test failure against >1.4 cluster <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: Fixing upgrade test kubernetes-e2e-gke-1.3-1.4-upgrade-cluster Proportionally scale deployments was introduced in v1.4 (kubernetes#20273), which caused this 1.3 test to fail on 1.4 clusters. This is cherrypicked into 1.3 merely for fixing test failues on kubernetes-e2e-gke-1.3-1.4-upgrade-cluster **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes#32710 **Special notes for your reviewer**: **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixing upgrade test kubernetes-e2e-gke-1.3-1.4-upgrade-cluster
Proportionally scale deployments was introduced in v1.4 (#20273),
which caused this 1.3 test to fail on 1.4 clusters.
This is cherrypicked into 1.3 merely for fixing test failues on
kubernetes-e2e-gke-1.3-1.4-upgrade-cluster
Which issue this PR fixes (optional, in
fixes #<issue number>(, #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #32710Special notes for your reviewer:
Release note:
This change is