GCE e2e build/test passed for commit 9e180fe.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

I would like to shadow this code review

this is blocking #33698

@ymqytw Would you shadow this as well?

@janetkuo Let me know if you don't have bandwidth for this

Please add a test for this, e.g. in hack/make-rules/test-cmd.sh

Looks good for now, but need rebase and a test.

@ymqytw I rebased and added a test

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

pkg/kubectl/resource/builder.go, line 713 at r2 (raw file):

      return &Result{err: fmt.Errorf("name cannot be provided when a selector is specified")}
  }

It should return a error, if len(b.resourceTuples) != 0, shouldn't it?

Comments from Reviewable

@ymqytw Agree. fixed.

Jenkins GKE smoke e2e failed for commit 6339d91. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

LGTM

@k8s-bot e2e test this please, issue: #33672

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@mikedanese Does this support filtering for all commands that support --filename?

@bgrant0607 it adds infrastructure to but individual commands need to be slightly retrofitted.