Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move push-ci-build.sh to kubernetes/release repo #32444

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Move push-ci-build.sh to kubernetes/release repo #32444

merged 1 commit into from
Sep 13, 2016

Conversation

david-mcmahon
Copy link
Contributor

@david-mcmahon david-mcmahon commented Sep 10, 2016 •
edited by k8s-oncall
Loading

This change is Reviewable

@david-mcmahon david-mcmahon added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 10, 2016
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2016
@k8s-bot
Copy link

k8s-bot commented Sep 10, 2016

GCE e2e build/test passed for commit f912317.

@ixdy ixdy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2016
@spxtr
Copy link
Contributor

spxtr commented Sep 12, 2016

I've noticed in CHANGELOG.md there are some references to this file. Is it worth adding a note saying that we're removing it?

@david-mcmahon david-mcmahon added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 12, 2016
@david-mcmahon david-mcmahon changed the title Remove missed push-ci-build.sh removal! Move push-ci-build.sh to kubernetes/release repo Sep 12, 2016
@david-mcmahon
Copy link
Contributor Author

@spxtr, good point. Updated PR description and added release-note label.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 13, 2016

GCE e2e build/test passed for commit f912317.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 42ab6ad into kubernetes:master Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

@ixdy ixdy

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@david-mcmahon @k8s-bot @spxtr @k8s-github-robot @googlebot @ixdy