Fix a bug in kubelet hostport logic which flushes KUBE-MARK-MASQ iptables chain #32413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freehan
added
priority/important-soon
thockin
added
priority/critical-urgent
thockin
changed the title
thockin
removed
the
priority/important-soon
k8s-github-robot
added
the
size/XS
|
at line 291 we also reference iptablesproxy.KubeMarkMasqChain - can you open a bug to create a new package under kubelet that exposes those constants? I don't like the cross-reference. |
thockin
added
the
lgtm
|
Sure. will do |
This was referenced Sep 9, 2016
pwittrock
added
the
cherry-pick-approved
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
fabioy
added a commit
that referenced
this pull request
Sep 9, 2016
…3-upstream-release-1.3 Automated cherry pick of #32413
|
GCE e2e build/test passed for commit 118ebd5. |
|
Automatic merge from submit-queue |
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-of-#31990-kubernetes#32413-kubernetes#32424-kubernetes#32404-kubernetes#32163-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#31990 kubernetes#32413 kubernetes#32424 kubernetes#32404 kubernetes#32163 Cherry pick of kubernetes#31990 kubernetes#32413 kubernetes#32424 kubernetes#32404 kubernetes#32163 on release-1.4. Batch 8
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…k-of-#32413-upstream-release-1.3 Automated cherry pick of kubernetes#32413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32415
This change is