add local subject access review API #32407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
kind/api-change
| Create(sar *authorizationapi.LocalSubjectAccessReview) (result *authorizationapi.LocalSubjectAccessReview, err error) | ||
| } | ||
|
|
||
| func (c *localSubjectAccessReviews) Create(sar *authorizationapi.LocalSubjectAccessReview) (result *authorizationapi.LocalSubjectAccessReview, err error) { |
There was a problem hiding this comment.
you'll need to manually create this for the fake generated client as well, right?
|
surprised there were no doc changes for the endpoint. do we need to hook up api doc generation for this api group? |
|
oh, no :) |
Eh, assume I fix up the quibbling generators. |
|
LGTM, modulo fake client method and generated bits |
liggitt
added
release-note
deads2k
force-pushed
the
authz-01-lsar
branch
from
336d6ab to
b2abdc8
Compare
deads2k
added
the
lgtm
|
Junit didn't report |
|
@deads2k |
deads2k
force-pushed
the
authz-01-lsar
branch
from
b2abdc8 to
356f890
Compare
deads2k
added
lgtm
deads2k
force-pushed
the
authz-01-lsar
branch
from
356f890 to
e5dbfda
Compare
deads2k
added
lgtm
|
GCE e2e build/test passed for commit e5dbfda. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 1, 2016
Automatic merge from submit-queue Run hack/update-codegen.sh in release-1.4 for generating an updated 1.4 clientset @caesarxuchao doing steps 1 and 2 as described here #33851 (comment) adds apps, authentication, certificates, rbac, and storage. The reason there are substantial deletions (aside from the oneliner "this package is generated by client-gen with arguments...") is because PR #32407 added a resource to the 1.4 clientset even though the resource is not present in 1.4 and the PR is targeted to 1.5. So this corrects that, as a bonus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a local subject access review endpoint to allow a project-admin (someone with full rights within a namespace) the power to inspect whether a person can perform an action in his namespace. This is a separate resource be factoring like this ensures that it is impossible for him to look outside his namespace and makes it possible to create authorization rules that can restrict this power to a project-admin in his own namespace. Other factorings require introspection of objects.
@kubernetes/sig-auth
This change is