Add script to push CI artifacts to gs://kubernetes-release/ci #3238
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-release/ci This pushes artifacts in a similar manner to the official release, except that instead of release/vFOO, it goes to ci/$(git describe), e.g.: gs://kubernetes-release/ci/v0.7.0-315-gcae5722 It also pushes a text file to gs://kubernetes-release/ci/latest.txt, so anyone can do, for instance: gsutil ls gs://kubernetes-release/ci/$(gsutil cat gs://kubernetes-release/ci/latest.txt) (In a parallel change, I'm going to flip the jenkins scripts over to use git describe, since it's shorter and a little more descriptive)
|
@jbeda: Ping? About to have an internal GKE commit that relies on this, too. |
| @@ -851,3 +852,20 @@ function kube::release::gcs::copy_release_artifacts() { | |||
|
|
|||
| gsutil ls -lhr "${gcs_destination}" | |||
| } | |||
|
|
|||
| function kube::release::gcs::publish_latest() { | |||
| local latest_file_dst="gs://${KUBE_GCS_RELEASE_BUCKET}/${KUBE_GCS_LATEST_FILE}" | |||
There was a problem hiding this comment.
We probably want to put this under `gs://${KUBE_GCS_RELEASE_BUCKET}/${KUBE_GCS_RELEASE_PREFIX}. That is the "series" of release and the real root of the release tree.
Actually, we probably need a new variable that is "release root" vs. "release version". Assuming that the bucket is the root means we can't have multiple "series" of releases in the same bucket.
Ah -- I see you encode the release root into ${KUBE_GCS_LATEST_FILE}. Ignore me.
|
LGTM -- feel free to tweak based on my (half assed) comments and self merge when you are ready. |
|
Self-merging after verbal LGTM from @jbeda. |
zmerlynn
added a commit
that referenced
this pull request
Jan 7, 2015
Add script to push CI artifacts to gs://kubernetes-release/ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pushes artifacts in a similar manner to the official release,
except that instead of release/vFOO, it goes to ci/$(git describe),
e.g.: gs://kubernetes-release/ci/v0.7.0-315-gcae5722
It also pushes a text file to gs://kubernetes-release/ci/latest.txt,
so anyone can do, for instance:
gsutil ls gs://kubernetes-release/ci/$(gsutil cat gs://kubernetes-release/ci/latest.txt)
(In a parallel change, I'm going to flip the jenkins scripts over to
use git describe, since it's shorter and a little more descriptive)