Change push-ci-build.sh to push-build.sh. #32235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
needs-rebase
david-mcmahon
force-pushed
the
push-build
branch
from
46c743a to
128b22c
Compare
|
How do we coordinate this with kubernetes/release#66? |
|
As |
david-mcmahon
added
release-note-none
|
@k8s-bot retest issue #UNKNOWN |
k8s-github-robot
added
the
needs-rebase
david-mcmahon
force-pushed
the
push-build
branch
from
128b22c to
23e0643
Compare
k8s-github-robot
added
size/M
|
@rmmh @ixdy @spxtr |
| "Exiting..." >&2 | ||
| exit 1 | ||
| if [[ ! -x ${push_build} ]]; then | ||
| # TODO: Remove/Restore this with the full deprecation PR |
There was a problem hiding this comment.
with this new logic, this shouldn't be an if/else, just an if.
|
GitHub still thinks there are merge conflicts, which is probably why this is failing. |
david-mcmahon
force-pushed
the
push-build
branch
2 times, most recently
from
e07fe56 to
b3892e1
Compare
david-mcmahon
force-pushed
the
push-build
branch
from
b3892e1 to
92ddc22
Compare
david-mcmahon
removed
the
needs-rebase
k8s-github-robot
added
size/S
ixdy
added
the
lgtm
|
GCE e2e build/test passed for commit 92ddc22. |
|
Automatic merge from submit-queue |
This was referenced Oct 24, 2016
roberthbailey
added a commit
that referenced
this pull request
Oct 25, 2016
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 27, 2016
…32235-#34359-#35233-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of #32013 #32235 #34359 #35233 Cherry pick of #32013 #32235 #34359 #35233 on release-1.4. #32013: Call push-ci-build.sh from the kubernetes/release repo. #32235: Change push-ci-build.sh to push-build.sh and some cleanup. #34359: Add support for adding a suffix to the GCS upload dir in #35233: Delete some old, dead release code
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…f-#32013-kubernetes#32235-kubernetes#34359-kubernetes#35233-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#32013 kubernetes#32235 kubernetes#34359 kubernetes#35233 Cherry pick of kubernetes#32013 kubernetes#32235 kubernetes#34359 kubernetes#35233 on release-1.4. kubernetes#32013: Call push-ci-build.sh from the kubernetes/release repo. kubernetes#32235: Change push-ci-build.sh to push-build.sh and some cleanup. kubernetes#34359: Add support for adding a suffix to the GCS upload dir in kubernetes#35233: Delete some old, dead release code
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…f-#28922-kubernetes#29892-kubernetes#30182-kubernetes#31025-kubernetes#32013-kubernetes#32235-kubernetes#34359-kubernetes#35233-upstream-release-1.3 Automated cherry pick of kubernetes#28922 kubernetes#29892 kubernetes#30182 kubernetes#31025 kubernetes#32013 kubernetes#32235 kubernetes#34359 kubernetes#35233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is