Disable gofmt for non go1.2 or go1.3 #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Travis failed on go1.2 and the error message isn't helpful... |
|
Yes, previous version was printing the name of the file that were not formatted. |
|
|
||
| bad=$(gofmt -s -l pkg/ cmd/) | ||
| if [ "$bad" != "0" ]; then | ||
| exit 1 |
proppy
added a commit
to proppy/kubernetes
that referenced
this pull request
Jul 1, 2014
workaround gofmt failure, until kubernetes#322 is in
|
@proppy turned off building at tip, so rebase, turn tip back on, and fix this at your leisure. :) |
|
Fixed, ptal. |
lavalamp
added a commit
that referenced
this pull request
Jul 1, 2014
Disable gofmt for non go1.2 or go1.3
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Misc cleanups
seans3
pushed a commit
to seans3/kubernetes
that referenced
this pull request
Apr 10, 2019
Move kubernetes#42336 to Enhancement of CLI
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
implement Resources func for applicationImpl
benluddy
added a commit
to benluddy/kubernetes
that referenced
this pull request
Sep 30, 2022
linxiulei
pushed a commit
to linxiulei/kubernetes
that referenced
this pull request
Jan 18, 2024
Bump base image debian-base to tag v1.0.0 to pick up some CVE fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.